[PR #2530] [MERGED] Enable readability-implicit-bool-conversion #2596

Closed
opened 2026-03-04 02:06:21 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2530
Author: @gaul
Created: 9/28/2024
Status: Merged
Merged: 9/28/2024
Merged by: @ggtakec

Base: masterHead: clang-tidy/implicit-bool-conversion


📝 Commits (1)

  • 85afb5c Enable readability-implicit-bool-conversion

📊 Changes

4 files changed (+11 additions, -8 deletions)

View changed files

📝 .clang-tidy (+3 -1)
📝 src/curl.cpp (+4 -3)
📝 src/s3fs.cpp (+1 -1)
📝 src/s3fs_cred.cpp (+3 -3)

📄 Description

This fixes one real error, one misreported EPERM, and some false positives. References #2529.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2530 **Author:** [@gaul](https://github.com/gaul) **Created:** 9/28/2024 **Status:** ✅ Merged **Merged:** 9/28/2024 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `clang-tidy/implicit-bool-conversion` --- ### 📝 Commits (1) - [`85afb5c`](https://github.com/s3fs-fuse/s3fs-fuse/commit/85afb5c557950f61734cdf7424ddbecb7638fa96) Enable readability-implicit-bool-conversion ### 📊 Changes **4 files changed** (+11 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `.clang-tidy` (+3 -1) 📝 `src/curl.cpp` (+4 -3) 📝 `src/s3fs.cpp` (+1 -1) 📝 `src/s3fs_cred.cpp` (+3 -3) </details> ### 📄 Description This fixes one real error, one misreported `EPERM`, and some false positives. References #2529. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 02:06:21 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/s3fs-fuse#2596
No description provided.