[PR #2524] [MERGED] Fixed hardlink test for macos #2591

New issue

Closed

opened 2026-03-04 02:06:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:06:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2524
Author: @ggtakec
Created: 9/26/2024
Status: ✅ Merged
Merged: 9/26/2024
Merged by: @gaul

Base: master ← Head: fix/test_macos

📝 Commits (1)

226f6b2 Fixed hardlink test for macos

📊 Changes

1 file changed (+5 additions, -12 deletions)

View changed files

📝 test/integration-test-main.sh (+5 -12)

📄 Description

Relevant Issue (if applicable)

#2418

Details

Until recently, hardlink on macos-fuse-t was not implemented by s3fs and resulted in an error, but the error output was empty.
When I noticed currently, it was outputting "Input/output error".
This caused test_hardlink execution(which had a special branch for macos-fuse-t) to fail, so I fixed it.

Note, this error output may change in the future, but I will check again if it does.
(s3fs is returning an ENOTSUP error, and "Input/output error" seems inappropriate as the message.)

Although the test_hardlink test was fixed, other tests still fail, so the macos tests do not pass overall.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2524 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 9/26/2024 **Status:** ✅ Merged **Merged:** 9/26/2024 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix/test_macos` --- ### 📝 Commits (1) - [`226f6b2`](https://github.com/s3fs-fuse/s3fs-fuse/commit/226f6b2c0f095fdf487f4b71f1786ea93b24da35) Fixed hardlink test for macos ### 📊 Changes **1 file changed** (+5 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `test/integration-test-main.sh` (+5 -12) </details> ### 📄 Description ### Relevant Issue (if applicable) #2418 ### Details Until recently, hardlink on macos-fuse-t was not implemented by s3fs and resulted in an error, but the error output was empty. When I noticed currently, it was outputting `"Input/output error"`. This caused `test_hardlink` execution(which had a special branch for macos-fuse-t) to fail, so I fixed it. Note, this error output may change in the future, but I will check again if it does. (s3fs is returning an ENOTSUP error, and "Input/output error" seems inappropriate as the message.) Although the `test_hardlink` test was fixed, other tests still fail, so the macos tests do not pass overall. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>