[PR #2409] [MERGED] Fixed a bug that mounting with ksmid specified to fail #2524

New issue

Closed

opened 2026-03-04 02:05:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2409
Author: @ggtakec
Created: 2/12/2024
Status: ✅ Merged
Merged: 2/18/2024
Merged by: @gaul

Base: master ← Head: fix_kmsid

📝 Commits (1)

9092542 Fixed a bug that mounting with ksmid specified to fail

📊 Changes

3 files changed (+47 additions, -13 deletions)

View changed files

📝 src/curl.cpp (+2 -2)
📝 src/curl.h (+1 -1)
📝 src/s3fs.cpp (+44 -10)

📄 Description

Relevant Issue (if applicable)

#2401

Details

If the bucket(or directory under the bucket) user attempt to mount is not created as SSE, a GET request(with the x-amz-server-side-encryption header) to check the mount point will return an error(InvalidArgument: x-amz-server-side-encryption header is not supported for this operation).

Thus, if the bucket did not have SSE settings(get error response), I changed that s3fs retried to send the GET request without x-amz-server-side-encryption header to check the mount point.

@gaul
If there are multiple causes for an error when making a GET request to check a mount point, the error details will be returned in order on each attempt, so the trial processing has been changed to a loop and refactored.
(I have added this recovering code, but the basic logic has not changed.)

This is a PR that fixes a bug reported by @aczire.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2409 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 2/12/2024 **Status:** ✅ Merged **Merged:** 2/18/2024 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_kmsid` --- ### 📝 Commits (1) - [`9092542`](https://github.com/s3fs-fuse/s3fs-fuse/commit/909254292af0448ae0a2e60484f54759ca5df30a) Fixed a bug that mounting with ksmid specified to fail ### 📊 Changes **3 files changed** (+47 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+2 -2) 📝 `src/curl.h` (+1 -1) 📝 `src/s3fs.cpp` (+44 -10) </details> ### 📄 Description ### Relevant Issue (if applicable) #2401 ### Details If the bucket(or directory under the bucket) user attempt to mount is not created as SSE, a GET request(with the `x-amz-server-side-encryption` header) to check the mount point will return an error(InvalidArgument: `x-amz-server-side-encryption` header is not supported for this operation). Thus, if the bucket did not have SSE settings(get error response), I changed that s3fs retried to send the GET request without `x-amz-server-side-encryption` header to check the mount point. @gaul If there are multiple causes for an error when making a GET request to check a mount point, the error details will be returned in order on each attempt, so the trial processing has been changed to a loop and refactored. (I have added this recovering code, but the basic logic has not changed.) This is a PR that fixes a bug reported by @aczire. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>