[PR #2502] [MERGED] Acquire lock before logging #2584

New issue

Closed

opened 2026-03-04 02:06:17 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:06:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2502
Author: @gaul
Created: 7/17/2024
Status: ✅ Merged
Merged: 7/21/2024
Merged by: @ggtakec

Base: master ← Head: locking/logging

📝 Commits (1)

9c33fef Acquire lock before logging

📊 Changes

1 file changed (+10 additions, -9 deletions)

View changed files

📝 src/fdcache_entity.cpp (+10 -9)

📄 Description

This is not safe -- another caller could modify a std::string field while logging which could read an invalid pointer. References #2490.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2502 **Author:** [@gaul](https://github.com/gaul) **Created:** 7/17/2024 **Status:** ✅ Merged **Merged:** 7/21/2024 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `locking/logging` --- ### 📝 Commits (1) - [`9c33fef`](https://github.com/s3fs-fuse/s3fs-fuse/commit/9c33fef8dabe0d47820f16cd43e0548caa1322c2) Acquire lock before logging ### 📊 Changes **1 file changed** (+10 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache_entity.cpp` (+10 -9) </details> ### 📄 Description This is not safe -- another caller could modify a `std::string` field while logging which could read an invalid pointer. References #2490. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>