[PR #2344] [MERGED] Changed argument name in ParallelMultipartUploadAll #2490

New issue

Closed

opened 2026-03-04 02:05:48 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2344
Author: @ggtakec
Created: 10/7/2023
Status: ✅ Merged
Merged: 10/9/2023
Merged by: @gaul

Base: master ← Head: fix_arg_name

📝 Commits (1)

25927bc Changed argument name in ParallelMultipartUploadAll

📊 Changes

2 files changed (+5 additions, -5 deletions)

View changed files

📝 src/fdcache_fdinfo.cpp (+4 -4)
📝 src/fdcache_fdinfo.h (+1 -1)

📄 Description

Relevant Issue (if applicable)

n/a

Details

The name of the argument (upload_list) of the PseudoFdInfo::ParallelMultipartUploadAll method was changed to to_upload_list.
The PseudoFdInfo class has a upload_list member variable, so it is confusing to use the same name, so you should change it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2344 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 10/7/2023 **Status:** ✅ Merged **Merged:** 10/9/2023 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_arg_name` --- ### 📝 Commits (1) - [`25927bc`](https://github.com/s3fs-fuse/s3fs-fuse/commit/25927bc1fa0dc0162e78b6c9eca56423a88ab146) Changed argument name in ParallelMultipartUploadAll ### 📊 Changes **2 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache_fdinfo.cpp` (+4 -4) 📝 `src/fdcache_fdinfo.h` (+1 -1) </details> ### 📄 Description ### Relevant Issue (if applicable) n/a ### Details The name of the argument (`upload_list`) of the `PseudoFdInfo::ParallelMultipartUploadAll` method was changed to `to_upload_list`. The `PseudoFdInfo` class has a `upload_list` member variable, so it is confusing to use the same name, so you should change it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>