[PR #2231] [MERGED] Refixed for cppcheck 2.1x #2403

New issue

Closed

opened 2026-03-04 02:05:21 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2231
Author: @ggtakec
Created: 7/25/2023
Status: ✅ Merged
Merged: 7/25/2023
Merged by: @gaul

Base: master ← Head: fix_cppcheck

📝 Commits (1)

3bf920a Refixed for cppcheck 2.1x

📊 Changes

20 files changed (+88 additions, -60 deletions)

View changed files

📝 .github/workflows/ci.yml (+2 -2)
📝 Makefile.am (+1 -0)
📝 src/cache.cpp (+8 -2)
📝 src/curl.cpp (+35 -30)
📝 src/fdcache.cpp (+1 -1)
📝 src/fdcache.h (+1 -1)
📝 src/fdcache_auto.cpp (+1 -1)
📝 src/fdcache_auto.h (+1 -1)
📝 src/fdcache_entity.cpp (+7 -7)
📝 src/fdcache_entity.h (+2 -2)
📝 src/fdcache_fdinfo.cpp (+8 -0)
📝 src/fdcache_page.cpp (+2 -6)
📝 src/openssl_auth.cpp (+3 -0)
📝 src/s3fs.cpp (+7 -0)
📝 src/s3fs_cred.cpp (+3 -3)
📝 src/string_util.cpp (+1 -1)
📝 src/threadpoolman.cpp (+2 -0)
📝 test/cr_filename.c (+1 -1)
📝 test/junk_data.c (+1 -1)
📝 test/mknod_test.c (+1 -1)

📄 Description

Relevant Issue (if applicable)

#2197

Details

Fixed a description error in ci.yml in #2197.
(Due to this description error, current code cannot be executed cppcheck.)
Also, #2197 was in the process of supporting cppcheck 2.1x, so I fixed it to support it correctly.
(verified with cppcheck 2.11.1)

The following parts have not been modified. (avoided by suppress inline comment)

Make arguments of Callback function to const
Judgment statements for functions that return only true

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2231 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 7/25/2023 **Status:** ✅ Merged **Merged:** 7/25/2023 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_cppcheck` --- ### 📝 Commits (1) - [`3bf920a`](https://github.com/s3fs-fuse/s3fs-fuse/commit/3bf920ae79339a1aa550d794490c2156e3f5f7f1) Refixed for cppcheck 2.1x ### 📊 Changes **20 files changed** (+88 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+2 -2) 📝 `Makefile.am` (+1 -0) 📝 `src/cache.cpp` (+8 -2) 📝 `src/curl.cpp` (+35 -30) 📝 `src/fdcache.cpp` (+1 -1) 📝 `src/fdcache.h` (+1 -1) 📝 `src/fdcache_auto.cpp` (+1 -1) 📝 `src/fdcache_auto.h` (+1 -1) 📝 `src/fdcache_entity.cpp` (+7 -7) 📝 `src/fdcache_entity.h` (+2 -2) 📝 `src/fdcache_fdinfo.cpp` (+8 -0) 📝 `src/fdcache_page.cpp` (+2 -6) 📝 `src/openssl_auth.cpp` (+3 -0) 📝 `src/s3fs.cpp` (+7 -0) 📝 `src/s3fs_cred.cpp` (+3 -3) 📝 `src/string_util.cpp` (+1 -1) 📝 `src/threadpoolman.cpp` (+2 -0) 📝 `test/cr_filename.c` (+1 -1) 📝 `test/junk_data.c` (+1 -1) 📝 `test/mknod_test.c` (+1 -1) </details> ### 📄 Description ### Relevant Issue (if applicable) #2197 ### Details Fixed a description error in ci.yml in #2197. (Due to this description error, current code cannot be executed cppcheck.) Also, #2197 was in the process of supporting cppcheck 2.1x, so I fixed it to support it correctly. (verified with cppcheck 2.11.1) The following parts have not been modified. (avoided by `suppress` inline comment) - Make arguments of Callback function to const - Judgment statements for functions that return only true --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>