[PR #1888] [MERGED] Include climits to support musl libc #2231

New issue

Closed

opened 2026-03-04 02:04:28 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:04:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1888
Author: @arkamar
Created: 2/13/2022
Status: ✅ Merged
Merged: 2/14/2022
Merged by: @gaul

Base: master ← Head: limits

📝 Commits (1)

8941855 Include climits to support musl libc

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src/fdcache.cpp (+1 -0)

📄 Description

PATH_MAX constant is not visible from any of currently included header files in system with musl libc, where compilation fails with an error below. The constant is defined in limits.h which is directly include via climits header file.

fdcache.cpp: In static member function 'static FILE* FdManager::MakeTempFile()':
fdcache.cpp:381:14: error: 'PATH_MAX' was not declared in this scope
  381 |     char cfn[PATH_MAX];
      |              ^~~~~~~~

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1888 **Author:** [@arkamar](https://github.com/arkamar) **Created:** 2/13/2022 **Status:** ✅ Merged **Merged:** 2/14/2022 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `limits` --- ### 📝 Commits (1) - [`8941855`](https://github.com/s3fs-fuse/s3fs-fuse/commit/89418551a8f931ea95839927fa5bd16e768c6840) Include climits to support musl libc ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache.cpp` (+1 -0) </details> ### 📄 Description `PATH_MAX` constant is not visible from any of currently included header files in system with musl libc, where compilation fails with an error below. The constant is defined in `limits.h` which is directly include via `climits` header file. ``` fdcache.cpp: In static member function 'static FILE* FdManager::MakeTempFile()': fdcache.cpp:381:14: error: 'PATH_MAX' was not declared in this scope 381 | char cfn[PATH_MAX]; | ^~~~~~~~ ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>