[PR #2135] [MERGED] Changed to rename cache files when renaming large files #2354

New issue

Closed

opened 2026-03-04 02:05:06 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2135
Author: @ggtakec
Created: 3/19/2023
Status: ✅ Merged
Merged: 3/21/2023
Merged by: @ggtakec

Base: master ← Head: rm_opened_file

📝 Commits (1)

a2ff26d Changed to rename cache files when renaming large files

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 src/s3fs.cpp (+4 -1)

📄 Description

Relevant Issue (if applicable)

#2128 #2130

Details

Always deleted cache files when renaming large files(these files use multipart uploading).
The cache file for these files should have been renamed in the same way as for non-large files, so this PR changed it to rename the cache file.

This was revealed by the bug reported by #2128.

FUSE temporarily changes the file name to /.fuse_hiddenXXXYYY if the opened file is deleted by another process etc.
When the opened file is closed, this temporarily file is also deleted.
In #2128, the cache file was deleted without being renamed after renaming, so the cache filewhich under the mirror directory remained.
(Files under the mirror directory are for file descriptors used when opening files.)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2135 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 3/19/2023 **Status:** ✅ Merged **Merged:** 3/21/2023 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `rm_opened_file` --- ### 📝 Commits (1) - [`a2ff26d`](https://github.com/s3fs-fuse/s3fs-fuse/commit/a2ff26df4d7a6982444585133d900066cb686570) Changed to rename cache files when renaming large files ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+4 -1) </details> ### 📄 Description ### Relevant Issue (if applicable) #2128 #2130 ### Details Always deleted cache files when renaming large files(these files use multipart uploading). The cache file for these files should have been renamed in the same way as for non-large files, so this PR changed it to rename the cache file. This was revealed by the bug reported by #2128. FUSE temporarily changes the file name to `/.fuse_hiddenXXXYYY` if the opened file is deleted by another process etc. When the opened file is closed, this temporarily file is also deleted. In #2128, the cache file was deleted without being renamed after renaming, so the cache filewhich under the mirror directory remained. (Files under the mirror directory are for file descriptors used when opening files.) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>