[PR #1714] [MERGED] Splited some methods of FdEntity class by uploading mode #2135

New issue

Closed

opened 2026-03-04 02:03:53 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:03:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1714
Author: @ggtakec
Created: 7/4/2021
Status: ✅ Merged
Merged: 7/10/2021
Merged by: @gaul

Base: master ← Head: split_methods

📝 Commits (1)

167bb64 Splited some methods of FdEntity class by uploading mode

📊 Changes

2 files changed (+434 additions, -101 deletions)

View changed files

📝 src/fdcache_entity.cpp (+428 -101)
📝 src/fdcache_entity.h (+6 -0)

📄 Description

Relevant Issue (if applicable)

n/a

Details

This is not a bug or a fix for a logic change.

The FdEntity::RowFlush and FdEntity::Write methods are common method for all uploading options(nomultipart, multipart, mixmaultipart).

Depending on the upload mode, the processing of these methods is roughly similar logic, but slightly different.
For this reason, we should be aware of the impact on other modes when modifying or changing methods.

I've split these methods in consideration of adding more modes in the future.
The processing of multipart and mixmultipart is very similar and seems verbose, but I focused on mode specific independence.

@gaul Please give me your opinion.
I thought it would be better to split it when adding a new mode(ex. adding new mode which is uploading file as a stream).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1714 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 7/4/2021 **Status:** ✅ Merged **Merged:** 7/10/2021 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `split_methods` --- ### 📝 Commits (1) - [`167bb64`](https://github.com/s3fs-fuse/s3fs-fuse/commit/167bb64c4577bccdae8b1b3dbe44ba168c35c568) Splited some methods of FdEntity class by uploading mode ### 📊 Changes **2 files changed** (+434 additions, -101 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache_entity.cpp` (+428 -101) 📝 `src/fdcache_entity.h` (+6 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) n/a ### Details This is not a bug or a fix for a logic change. The `FdEntity::RowFlush` and `FdEntity::Write` methods are common method for all uploading options(`nomultipart`, `multipart`, `mixmaultipart`). Depending on the upload mode, the processing of these methods is roughly similar logic, but slightly different. For this reason, we should be aware of the impact on other modes when modifying or changing methods. I've split these methods in consideration of adding more modes in the future. The processing of `multipart` and `mixmultipart` is very similar and seems verbose, but I focused on mode specific independence. @gaul Please give me your opinion. I thought it would be better to split it when adding a new mode(ex. adding new mode which is uploading file as a stream). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>