[PR #2116] [MERGED] Updated files for support ALPINE v3.17 #2342

Closed
opened 2026-03-04 02:05:02 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2116
Author: @ggtakec
Created: 2/19/2023
Status: Merged
Merged: 3/5/2023
Merged by: @ggtakec

Base: masterHead: support_alpine


📝 Commits (1)

  • a3bfc6a Updated files for support ALPINE v3.17

📊 Changes

5 files changed (+68 additions, -20 deletions)

View changed files

📝 .github/workflows/ci.yml (+1 -0)
📝 .github/workflows/linux-ci-helper.sh (+48 -11)
📝 autogen.sh (+3 -2)
📝 src/curl.cpp (+4 -1)
📝 test/integration-test-main.sh (+12 -6)

📄 Description

Relevant Issue (if applicable)

#2046 #2110

Details

Enabled to execute Github Actions(CI) for ALPINE(v3.17).

This change includes the following changes:

linux-ci-helper.sh

Changed from bash to sh. (because the initial image of ALPINE does not include bash)
Created a condition for ALPINE and made modifications accordingly.

autogen.sh

ALPINE's autoconf is new and needs to be updated in configure.ac.
However, some supported older OS's don't support the new KEYWORDS in configure.ac, so I've added autoupdated for it.

curl.cpp

Changed CURLOPT_PUT to CURLOPT_UPLOAD.
CURLOPT_PROGRESSFUNCTION should be changed to CURLOPT_XFERINFOFUNCTION, but it was not changed because we have an OS that uses old curl.
Compiling on ALPINE will output a warning, which can be ignored.

integration-test-main.sh

In ALPINE, the ENOTSUP error is output as Not supported instead of Operation not supported, so it have been fixed.
test_overwrite_existing_file_range was doing file comparison with redirection, which often failed in ALPINE.
This error has been eliminated by creating a real file for this comparison, so this has been fixed.
(This fix does not affect testing.)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2116 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 2/19/2023 **Status:** ✅ Merged **Merged:** 3/5/2023 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `support_alpine` --- ### 📝 Commits (1) - [`a3bfc6a`](https://github.com/s3fs-fuse/s3fs-fuse/commit/a3bfc6ad35d5ec77d9e4fc956fdffc4e436f97e6) Updated files for support ALPINE v3.17 ### 📊 Changes **5 files changed** (+68 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+1 -0) 📝 `.github/workflows/linux-ci-helper.sh` (+48 -11) 📝 `autogen.sh` (+3 -2) 📝 `src/curl.cpp` (+4 -1) 📝 `test/integration-test-main.sh` (+12 -6) </details> ### 📄 Description ### Relevant Issue (if applicable) #2046 #2110 ### Details Enabled to execute Github Actions(CI) for ALPINE(v3.17). This change includes the following changes: #### `linux-ci-helper.sh` Changed from `bash` to `sh`. (because the initial image of ALPINE does not include `bash`) Created a condition for ALPINE and made modifications accordingly. #### `autogen.sh` ALPINE's `autoconf` is new and needs to be updated in `configure.ac`. However, some supported older OS's don't support the new KEYWORDS in configure.ac, so I've added `autoupdated` for it. #### `curl.cpp` Changed `CURLOPT_PUT` to `CURLOPT_UPLOAD`. `CURLOPT_PROGRESSFUNCTION` should be changed to `CURLOPT_XFERINFOFUNCTION`, but it was not changed because we have an OS that uses old curl. Compiling on ALPINE will output a warning, which can be ignored. #### integration-test-main.sh In ALPINE, the `ENOTSUP` error is output as `Not supported` instead of `Operation not supported`, so it have been fixed. `test_overwrite_existing_file_range` was doing file comparison with redirection, which often failed in ALPINE. This error has been eliminated by creating a real file for this comparison, so this has been fixed. (This fix does not affect testing.) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 02:05:02 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/s3fs-fuse#2342
No description provided.