[PR #1689] [MERGED] Fixed a bug utimens is calling before flush #2116

New issue

Closed

opened 2026-03-04 02:03:47 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:03:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1689
Author: @ggtakec
Created: 6/20/2021
Status: ✅ Merged
Merged: 6/21/2021
Merged by: @gaul

Base: master ← Head: fix_utimens_during_mp

📝 Commits (2)

da43467 Fixed a bug utimens is calling before flush
98d8679 Added test case for utimens is calling during multipart upload

📊 Changes

2 files changed (+16 additions, -1 deletions)

View changed files

📝 src/fdcache_entity.cpp (+1 -1)
📝 test/integration-test-main.sh (+15 -0)

📄 Description

Relevant Issue (if applicable)

#1685

Details

In the case where utimens was called before flush after updating the file was called, it was wrong to determine that it was being updated.
(It seems to have existed for a long time, but it may have become apparent with the modification of #1666.)
There was a file fix that required the meta data to be updated, and I was getting an error because I was doing an upload with utimens before uploading that meta information.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1689 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 6/20/2021 **Status:** ✅ Merged **Merged:** 6/21/2021 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_utimens_during_mp` --- ### 📝 Commits (2) - [`da43467`](https://github.com/s3fs-fuse/s3fs-fuse/commit/da4346730a747135164e4b713b8b5fc25d430ef5) Fixed a bug utimens is calling before flush - [`98d8679`](https://github.com/s3fs-fuse/s3fs-fuse/commit/98d867954578b0b03f2b4addf58f3cdf987fb071) Added test case for utimens is calling during multipart upload ### 📊 Changes **2 files changed** (+16 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache_entity.cpp` (+1 -1) 📝 `test/integration-test-main.sh` (+15 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) #1685 ### Details In the case where utimens was called before flush after updating the file was called, it was wrong to determine that it was being updated. (It seems to have existed for a long time, but it may have become apparent with the modification of #1666.) There was a file fix that required the meta data to be updated, and I was getting an error because I was doing an upload with utimens before uploading that meta information. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>