[PR #1747] [MERGED] fix misuse of IsUploading #2152

New issue

Closed

opened 2026-03-04 02:04:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:04:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1747
Author: @VVoidV
Created: 8/24/2021
Status: ✅ Merged
Merged: 8/29/2021
Merged by: @ggtakec

Base: master ← Head: fix_IsUploading

📝 Commits (2)

74c669d fix misuse of IsUploading
86bc953 Merge branch 'master' into fix_IsUploading

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 src/fdcache_fdinfo.cpp (+3 -3)

📄 Description

Relevant Issue (if applicable)

When disk cache space is not enough, write file will failed with EIO.

Details

IsUploading() return false when upload_id is assigned, I think here we misused it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1747 **Author:** [@VVoidV](https://github.com/VVoidV) **Created:** 8/24/2021 **Status:** ✅ Merged **Merged:** 8/29/2021 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `fix_IsUploading` --- ### 📝 Commits (2) - [`74c669d`](https://github.com/s3fs-fuse/s3fs-fuse/commit/74c669d3de5d13564b90f0953ed5d3d47e1bfd2f) fix misuse of IsUploading - [`86bc953`](https://github.com/s3fs-fuse/s3fs-fuse/commit/86bc95371fd946a417507c5639ab6dbd5ea3b6a6) Merge branch 'master' into fix_IsUploading ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache_fdinfo.cpp` (+3 -3) </details> ### 📄 Description ### Relevant Issue (if applicable) When disk cache space is not enough, write file will failed with EIO. ### Details IsUploading() return false when upload_id is assigned, I think here we misused it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>