[PR #993] [MERGED] Fixed a bug about overwrite metadata at updating directory stats #1747

New issue

Closed

opened 2026-03-04 02:01:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:01:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/993
Author: @ggtakec
Created: 3/29/2019
Status: ✅ Merged
Merged: 3/29/2019
Merged by: @ggtakec

Base: master ← Head: test

📝 Commits (1)

ea517c8 Fixed a bug about overwrite metadata at updating directory stats

📊 Changes

1 file changed (+17 additions, -12 deletions)

View changed files

📝 src/s3fs.cpp (+17 -12)

📄 Description

Relevant Issue (if applicable)

#730

Details

When updating directory stats, directory objects were always re-created.

A directory object that s3fs recognizes and creates as a directory is an object of dir/ path.
If there are other directory object (dir) or no directory object in the bucket, s3fs can recognize them as directories.
When updating directory statistics (metadata), s3fs will delete and recreate directory objects other than dir/ types.
(This is able to convert other directory object type to a dir/ object)

However, there was a bug in determining the type of this directory object, and the directory object was always recreated.

In this PR, it has been modified to make the right decision.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/993 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 3/29/2019 **Status:** ✅ Merged **Merged:** 3/29/2019 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `test` --- ### 📝 Commits (1) - [`ea517c8`](https://github.com/s3fs-fuse/s3fs-fuse/commit/ea517c80a4a74d48c22d75001700357382f292bc) Fixed a bug about overwrite metadata at updating directory stats ### 📊 Changes **1 file changed** (+17 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+17 -12) </details> ### 📄 Description ### Relevant Issue (if applicable) #730 ### Details When updating directory stats, directory objects were always re-created. A directory object that s3fs recognizes and creates as a directory is an object of `dir/` path. If there are other directory object (`dir`) or `no directory object` in the bucket, s3fs can recognize them as directories. When updating directory statistics (metadata), s3fs will delete and recreate directory objects other than `dir/` types. (This is able to convert other directory object type to a `dir/` object) However, there was a bug in determining the type of this directory object, and the directory object was always recreated. In this PR, it has been modified to make the right decision. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>