[PR #1698] [MERGED] Fixed a bug about rename existing file of different sizes by mpcopy #2124

New issue

Closed

opened 2026-03-04 02:03:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:03:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1698
Author: @ggtakec
Created: 6/25/2021
Status: ✅ Merged
Merged: 6/25/2021
Merged by: @gaul

Base: master ← Head: fix_rename_bug

📝 Commits (1)

d4f4d22 Fixed a bug about rename existing file of different sizes by mpcopy

📊 Changes

3 files changed (+28 additions, -8 deletions)

View changed files

📝 src/fdcache_entity.cpp (+1 -1)
📝 src/s3fs.cpp (+13 -7)
📝 test/integration-test-main.sh (+14 -0)

📄 Description

Relevant Issue (if applicable)

#1695

Details

In the move(rename) logic of the file, there was a problem that it failed when the destination file existed and the size was different.
When moving(renaming) file, it made a mistake the file size of the source file and the destination file.
This happened for files of a size that would be subject to multipart upload(copy).
And added a simple test case, too.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1698 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 6/25/2021 **Status:** ✅ Merged **Merged:** 6/25/2021 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_rename_bug` --- ### 📝 Commits (1) - [`d4f4d22`](https://github.com/s3fs-fuse/s3fs-fuse/commit/d4f4d22252cf75f2826f3d4a75932f143eae5c39) Fixed a bug about rename existing file of different sizes by mpcopy ### 📊 Changes **3 files changed** (+28 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache_entity.cpp` (+1 -1) 📝 `src/s3fs.cpp` (+13 -7) 📝 `test/integration-test-main.sh` (+14 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) #1695 ### Details In the move(rename) logic of the file, there was a problem that it failed when the destination file existed and the size was different. When moving(renaming) file, it made a mistake the file size of the source file and the destination file. This happened for files of a size that would be subject to multipart upload(copy). And added a simple test case, too. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>