[PR #913] [MERGED] Prefer abort over assert(false) #1695

New issue

Closed

opened 2026-03-04 02:01:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:01:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/913
Author: @gaul
Created: 1/20/2019
Status: ✅ Merged
Merged: 1/21/2019
Merged by: @ggtakec

Base: master ← Head: assert

📝 Commits (1)

40ba3b4 Prefer abort over assert(false)

📊 Changes

4 files changed (+8 additions, -10 deletions)

View changed files

📝 src/addhead.cpp (+2 -3)
📝 src/cache.cpp (+2 -3)
📝 src/curl.cpp (+2 -1)
📝 src/fdcache.cpp (+2 -3)

📄 Description

The compiler can remove the latter when compiled with NDEBUG which may
cause unintended control flow.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/913 **Author:** [@gaul](https://github.com/gaul) **Created:** 1/20/2019 **Status:** ✅ Merged **Merged:** 1/21/2019 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `assert` --- ### 📝 Commits (1) - [`40ba3b4`](https://github.com/s3fs-fuse/s3fs-fuse/commit/40ba3b44a162dfa72e1259e3766e4b1291ebe444) Prefer abort over assert(false) ### 📊 Changes **4 files changed** (+8 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/addhead.cpp` (+2 -3) 📝 `src/cache.cpp` (+2 -3) 📝 `src/curl.cpp` (+2 -1) 📝 `src/fdcache.cpp` (+2 -3) </details> ### 📄 Description The compiler can remove the latter when compiled with `NDEBUG` which may cause unintended control flow. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>