[PR #1235] [MERGED] Set directory MIME type to application/x-directory #1879

Closed
opened 2026-03-04 02:02:36 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1235
Author: @gaul
Created: 2/2/2020
Status: Merged
Merged: 2/4/2020
Merged by: @gaul

Base: masterHead: mime-type


📝 Commits (1)

  • bc9126d Set directory MIME type to application/x-directory

📊 Changes

3 files changed (+13 additions, -1 deletions)

View changed files

📝 src/curl.cpp (+4 -0)
📝 src/s3fs.cpp (+0 -1)
📝 test/integration-test-main.sh (+9 -0)

📄 Description

Previously s3fs auto-detected the MIME type of directories like
"TOYOTA TRUCK 8.2.2" as application/x-troff-man. This caused get_mode
to not set S_IFDIR which failed directory creation. Instead force all
object names ending in / to application/x-directory. Fixes #1183.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1235 **Author:** [@gaul](https://github.com/gaul) **Created:** 2/2/2020 **Status:** ✅ Merged **Merged:** 2/4/2020 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `mime-type` --- ### 📝 Commits (1) - [`bc9126d`](https://github.com/s3fs-fuse/s3fs-fuse/commit/bc9126d774c70a2566e4b00202e20986a0100531) Set directory MIME type to application/x-directory ### 📊 Changes **3 files changed** (+13 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+4 -0) 📝 `src/s3fs.cpp` (+0 -1) 📝 `test/integration-test-main.sh` (+9 -0) </details> ### 📄 Description Previously s3fs auto-detected the MIME type of directories like "TOYOTA TRUCK 8.2.2" as application/x-troff-man. This caused `get_mode` to not set `S_IFDIR` which failed directory creation. Instead force all object names ending in / to application/x-directory. Fixes #1183. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 02:02:36 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/s3fs-fuse#1879
No description provided.