mirror of
https://github.com/s3fs-fuse/s3fs-fuse.git
synced 2026-04-25 05:16:00 +03:00
[GH-ISSUE #2405] Build error against >=libxml2-2.12 - s3fs.cpp:3492:27: error: xmlReadMemory was not declared in this scope; did you mean xmlInitMemory? #1183
Labels
No labels
bug
bug
dataloss
duplicate
enhancement
feature request
help wanted
invalid
need info
performance
pull-request
question
question
testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/s3fs-fuse#1183
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @a17r on GitHub (Jan 31, 2024).
Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/2405
Downstream report: https://bugs.gentoo.org/917522
Probably just a missing header - to quote libxml2 upstream changelog:
Additional Information
Version of s3fs being used (
s3fs --version)1.93
GNU/Linux Distribution, if applicable (
cat /etc/os-release)Gentoo
@ggtakec commented on GitHub (Feb 4, 2024):
It appears that 2.12 is not yet officially supported by any distribution other than Gentoo. And I haven't been able to confirm it directly yet.
Is it possible for you to confirm the following?
#include <libxml/parser.h>tosrc/s3fs_xml.h?Thanks in advance for your assistance.
@gaul commented on GitHub (Feb 13, 2024):
I tested this on Fedora 40 with libxml2-devel-2.12.5-1.fc40.x86_64 but could not reproduce these symptoms.
@a17r commented on GitHub (Feb 14, 2024):
The downstream bug was filed with
2.12.0, the circular dependency was readded to upstream headers for2.12.3, that's why you can't reproduce it:gitlab.gnome.org/GNOME/libxml2/-@72007096e2@ggtakec Gentoo is source-based so there are no separate -dev packages. Downstream build.log confirms successful libxml2 detection anyway. ;)
@a17r commented on GitHub (Feb 14, 2024):
Yes it fixes compilation. :)
@gaul commented on GitHub (Feb 14, 2024):
Can you submit a pull request for this?
@ggtakec commented on GitHub (Feb 19, 2024):
@a17r Thanks for your help.
To be clear, is this issue resolved in versions 2.12.3 and later?
@gaul
Even if I write to include
libxml/parser.hdirectly ins3fs_xml.h, it will not cause any problems when using versions other than2.12.0, but should I PR this and merge it?It may seem like a special case, but by adding it you can avoid problems with specific versions. (Although it is a waste of description, I think it is okay to write it.)
If this should be added, I can create a PR for this.
@a17r commented on GitHub (Feb 22, 2024):
@ggtakec thanks for making the PR. It is not so much that Gentoo needs it, rather that sources should include what they use, if in the future libxml2 will finally get rid of this then s3fs-fuse will no longer be affected.
@ggtakec commented on GitHub (Feb 23, 2024):
@a17r Excuse me, but let me confirm that I haven't misunderstood yet.
Does this mean that in the combination of Gentoo+libxml (2.12), there are still issues that are required in addition to the code merged by PR?
@a17r commented on GitHub (Feb 23, 2024):
No, your PR perfectly solves the issue, I was just alluding to the commit message mentioning Gentoo, when it is not really distro specific (at the time of issuing the PR already >=2.12.4 was available).
>=libxml2-2.12.3 simply put back the header to mitigate the amount of broken revdeps, but this is not guaranteed to stay in the future, so it is good this was fixed.
@ggtakec commented on GitHub (Feb 23, 2024):
@a17r Thank you for reply.
I'm glad that PR solved this problem.
This issue will be closed, but if you still have any problems, please reopen or create a new issue.