[PR #1066] [MERGED] Sign request immediately before sending #1787

New issue

Closed

opened 2026-03-04 02:02:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:02:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1066
Author: @gaul
Created: 7/2/2019
Status: ✅ Merged
Merged: 9/23/2019
Merged by: @ggtakec

Base: master ← Head: sign-requests

📝 Commits (1)

461a346 Sign request immediately before sending

📊 Changes

4 files changed (+18 additions, -135 deletions)

View changed files

📝 src/curl.cpp (+10 -48)
📝 src/gnutls_auth.cpp (+4 -44)
📝 src/nss_auth.cpp (+2 -22)
📝 src/openssl_auth.cpp (+2 -21)

📄 Description

Previously s3fs could create a long list of pre-signed requests which
could take longer than the default S3 clock skew limit of 15 minutes.
This also changes SHA-256 computation from single- to multi-threaded
since this is now computed in the worker threads. Regression from
88cd8feb05. Fixes #1019.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1066 **Author:** [@gaul](https://github.com/gaul) **Created:** 7/2/2019 **Status:** ✅ Merged **Merged:** 9/23/2019 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `sign-requests` --- ### 📝 Commits (1) - [`461a346`](https://github.com/s3fs-fuse/s3fs-fuse/commit/461a346bf48f5b620abd1414e373bd2ebaf44517) Sign request immediately before sending ### 📊 Changes **4 files changed** (+18 additions, -135 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+10 -48) 📝 `src/gnutls_auth.cpp` (+4 -44) 📝 `src/nss_auth.cpp` (+2 -22) 📝 `src/openssl_auth.cpp` (+2 -21) </details> ### 📄 Description Previously s3fs could create a long list of pre-signed requests which could take longer than the default S3 clock skew limit of 15 minutes. This also changes SHA-256 computation from single- to multi-threaded since this is now computed in the worker threads. Regression from 88cd8feb053980c808d67771d63a84ca25f6db8a. Fixes #1019. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>