starred/s3fs-fuse
1
0
Fork 0
mirror of https://github.com/s3fs-fuse/s3fs-fuse.git synced 2026-04-25 13:26:00 +03:00
Code Issues 305 Projects Releases 5 Packages Wiki Activity

[GH-ISSUE #2120] File content lost after write failure #1080

New issue
Closed
opened 2026-03-04 01:51:13 +03:00 by kerem · 5 comments
kerem commented 2026-03-04 01:51:13 +03:00
Owner
Copy link

Originally created by @adamqqqplay on GitHub (Feb 22, 2023).
Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/2120

When the user's IAM role does not have permission to write to the S3 Bucket, the file will lose its original data after overwriting.

Additional Information

Version of s3fs being used (s3fs --version)

V1.91 (commit:f8a825e)

Version of fuse being used (pkg-config --modversion fuse, rpm -qi fuse or dpkg -s fuse)

2.9.9

Kernel information (uname -r)

5.15.0-43-generic

GNU/Linux Distribution, if applicable (cat /etc/os-release)

PRETTY_NAME="Ubuntu 22.04.1 LTS"

How to run s3fs, if applicable

command line

sudo s3fs elune-s3-test -o check_cache_dir_exist -o use_cache=~/test/s3fs/cache -o passwd_file=~/test/s3fs/s3key.txt -o allow_other  -o auto_unmount -o entry_timeout=100000 -o attr_timeout=10000 -o dbglevel=info -f  ./mnt

s3fs syslog messages (grep s3fs /var/log/syslog, journalctl | grep s3fs, or s3fs outputs)

2023-02-22T07:40:19.093Z [INF] s3fs.cpp:s3fs_open(2650): [path=/test.txt][flags=0x8000]
2023-02-22T07:40:19.093Z [INF]       fdcache.cpp:GetFdEntity(484): [path=/test.txt][pseudo_fd=-1]
2023-02-22T07:40:19.093Z [INF]       cache.cpp:DelStat(596): delete stat cache entry[path=/test.txt]
2023-02-22T07:40:19.093Z [INF]       curl.cpp:HeadRequest(3295): [tpath=/test.txt]
2023-02-22T07:40:19.093Z [INF]       curl.cpp:PreHeadRequest(3255): [tpath=/test.txt][bpath=][save=][sseckeypos=18446744073709551615]
2023-02-22T07:40:19.093Z [INF]       curl_util.cpp:prepare_url(257): URL is https://s3-ap-southeast-1.amazonaws.com/elune-s3-test/test.txt
2023-02-22T07:40:19.093Z [INF]       curl_util.cpp:prepare_url(290): URL changed is https://elune-s3-test.s3-ap-southeast-1.amazonaws.com/test.txt
2023-02-22T07:40:19.093Z [INF]       curl.cpp:insertV4Headers(2888): computing signature [HEAD] [/test.txt] [] []
2023-02-22T07:40:19.093Z [INF]       curl_util.cpp:url_to_host(334): url is https://s3-ap-southeast-1.amazonaws.com
2023-02-22T07:40:19.173Z [INF]       curl.cpp:RequestPerform(2516): HTTP response code 200
2023-02-22T07:40:19.173Z [INF]       cache.cpp:AddStat(342): add stat cache entry[path=/test.txt]
2023-02-22T07:40:19.174Z [INF]       fdcache_entity.cpp:SetMCtime(828): [path=/test.txt][physical_fd=25][mtime=1677050283][ctime=1677050283]
2023-02-22T07:40:19.174Z [INF]       curl.cpp:GetObjectRequest(3640): [tpath=/test.txt][start=0][size=6]
2023-02-22T07:40:19.174Z [INF]       curl.cpp:PreGetObjectRequest(3586): [tpath=/test.txt][start=0][size=6]
2023-02-22T07:40:19.174Z [INF]       curl_util.cpp:prepare_url(257): URL is https://s3-ap-southeast-1.amazonaws.com/elune-s3-test/test.txt
2023-02-22T07:40:19.174Z [INF]       curl_util.cpp:prepare_url(290): URL changed is https://elune-s3-test.s3-ap-southeast-1.amazonaws.com/test.txt
2023-02-22T07:40:19.175Z [INF]       curl.cpp:GetObjectRequest(3659): downloading... [path=/test.txt][fd=25]
2023-02-22T07:40:19.175Z [INF]       curl.cpp:insertV4Headers(2888): computing signature [GET] [/test.txt] [] []
2023-02-22T07:40:19.175Z [INF]       curl_util.cpp:url_to_host(334): url is https://s3-ap-southeast-1.amazonaws.com
2023-02-22T07:40:19.258Z [INF]       curl.cpp:RequestPerform(2516): HTTP response code 206
2023-02-22T07:40:19.258Z [INF] s3fs.cpp:s3fs_flush(2816): [path=/test.txt][pseudo_fd=2]
2023-02-22T07:40:19.258Z [INF]       fdcache_entity.cpp:RowFlush(1404): [tpath=][path=/test.txt][pseudo_fd=2][physical_fd=25]
2023-02-22T07:40:19.258Z [INF]       cache.cpp:DelStat(596): delete stat cache entry[path=/test.txt]
2023-02-22T07:40:19.258Z [INF] s3fs.cpp:s3fs_release(2894): [path=/test.txt][pseudo_fd=2]
2023-02-22T07:40:19.258Z [INF]       fdcache.cpp:GetFdEntity(484): [path=/test.txt][pseudo_fd=2]

2023-02-22T07:40:31.342Z [INF] s3fs.cpp:s3fs_open(2650): [path=/test.txt][flags=0x8201]
2023-02-22T07:40:31.342Z [INF]       curl.cpp:HeadRequest(3295): [tpath=/test.txt]
2023-02-22T07:40:31.342Z [INF]       curl.cpp:PreHeadRequest(3255): [tpath=/test.txt][bpath=][save=][sseckeypos=18446744073709551615]
2023-02-22T07:40:31.342Z [INF]       curl_util.cpp:prepare_url(257): URL is https://s3-ap-southeast-1.amazonaws.com/elune-s3-test/test.txt
2023-02-22T07:40:31.342Z [INF]       curl_util.cpp:prepare_url(290): URL changed is https://elune-s3-test.s3-ap-southeast-1.amazonaws.com/test.txt
2023-02-22T07:40:31.342Z [INF]       curl.cpp:insertV4Headers(2888): computing signature [HEAD] [/test.txt] [] []
2023-02-22T07:40:31.342Z [INF]       curl_util.cpp:url_to_host(334): url is https://s3-ap-southeast-1.amazonaws.com
2023-02-22T07:40:31.690Z [INF]       curl.cpp:RequestPerform(2516): HTTP response code 200
2023-02-22T07:40:31.690Z [INF]       cache.cpp:AddStat(342): add stat cache entry[path=/test.txt]
2023-02-22T07:40:31.691Z [INF]       fdcache_entity.cpp:SetMCtime(828): [path=/test.txt][physical_fd=25][mtime=1677050283][ctime=1677050283]
2023-02-22T07:40:31.691Z [INF]       fdcache_entity.cpp:SetMCtime(828): [path=/test.txt][physical_fd=25][mtime=1677051631.691531478][ctime=1677051631.691531478]
2023-02-22T07:40:31.691Z [INF]       fdcache_entity.cpp:RowFlush(1404): [tpath=/test.txt][path=/test.txt][pseudo_fd=2][physical_fd=25]
2023-02-22T07:40:31.691Z [INF]       fdcache_entity.cpp:RowFlushMixMultipart(1629): [tpath=/test.txt][path=/test.txt][pseudo_fd=2][physical_fd=25]
2023-02-22T07:40:31.691Z [INF]       curl.cpp:PutRequest(3445): [tpath=/test.txt]
2023-02-22T07:40:31.691Z [INF]       curl_util.cpp:prepare_url(257): URL is https://s3-ap-southeast-1.amazonaws.com/elune-s3-test/test.txt
2023-02-22T07:40:31.691Z [INF]       curl_util.cpp:prepare_url(290): URL changed is https://elune-s3-test.s3-ap-southeast-1.amazonaws.com/test.txt
2023-02-22T07:40:31.691Z [INF]       curl.cpp:PutRequest(3573): uploading... [path=/test.txt][fd=25][size=0]
2023-02-22T07:40:31.691Z [INF]       curl.cpp:insertV4Headers(2888): computing signature [PUT] [/test.txt] [] [e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855]
2023-02-22T07:40:31.691Z [INF]       curl_util.cpp:url_to_host(334): url is https://s3-ap-southeast-1.amazonaws.com
2023-02-22T07:40:31.765Z [ERR] curl.cpp:RequestPerform(2563): HTTP response code 403, returning EPERM. Body Text: <?xml version="1.0" encoding="UTF-8"?>
<Error><Code>AccessDenied</Code><Message>Access Denied</Message><RequestId>6CPX1XR60SF0M5A3</RequestId><HostId>kMkTGxn9xztyWyx10RHpoFSDTizU3cTrkPVVZ+M8mAzsp6AMipVg069vWwGwRL+AVuVChGbXt8s=</HostId></Error>
2023-02-22T07:40:31.765Z [ERR] s3fs.cpp:s3fs_open(2713): could not upload file(/test.txt): result=-1
2023-02-22T07:40:31.765Z [INF]       cache.cpp:DelStat(596): delete stat cache entry[path=/test.txt]

2023-02-22T07:40:36.828Z [INF] s3fs.cpp:s3fs_open(2650): [path=/test.txt][flags=0x8000]
2023-02-22T07:40:36.828Z [INF]       curl.cpp:HeadRequest(3295): [tpath=/test.txt]
2023-02-22T07:40:36.828Z [INF]       curl.cpp:PreHeadRequest(3255): [tpath=/test.txt][bpath=][save=][sseckeypos=18446744073709551615]
2023-02-22T07:40:36.828Z [INF]       curl_util.cpp:prepare_url(257): URL is https://s3-ap-southeast-1.amazonaws.com/elune-s3-test/test.txt
2023-02-22T07:40:36.828Z [INF]       curl_util.cpp:prepare_url(290): URL changed is https://elune-s3-test.s3-ap-southeast-1.amazonaws.com/test.txt
2023-02-22T07:40:36.828Z [INF]       curl.cpp:insertV4Headers(2888): computing signature [HEAD] [/test.txt] [] []
2023-02-22T07:40:36.828Z [INF]       curl_util.cpp:url_to_host(334): url is https://s3-ap-southeast-1.amazonaws.com
2023-02-22T07:40:36.904Z [INF]       curl.cpp:RequestPerform(2516): HTTP response code 200
2023-02-22T07:40:36.904Z [INF]       cache.cpp:AddStat(342): add stat cache entry[path=/test.txt]
2023-02-22T07:40:36.906Z [INF]       fdcache_entity.cpp:SetMCtime(828): [path=/test.txt][physical_fd=25][mtime=1677050283][ctime=1677050283]
2023-02-22T07:40:36.906Z [INF] s3fs.cpp:s3fs_getattr(874): [path=/test.txt]
2023-02-22T07:40:36.906Z [INF] s3fs.cpp:s3fs_flush(2816): [path=/test.txt][pseudo_fd=2]
2023-02-22T07:40:36.906Z [INF]       fdcache_entity.cpp:RowFlush(1404): [tpath=][path=/test.txt][pseudo_fd=2][physical_fd=25]
2023-02-22T07:40:36.906Z [INF]       cache.cpp:DelStat(596): delete stat cache entry[path=/test.txt]
2023-02-22T07:40:36.906Z [INF] s3fs.cpp:s3fs_release(2894): [path=/test.txt][pseudo_fd=2]
2023-02-22T07:40:36.906Z [INF]       fdcache.cpp:GetFdEntity(484): [path=/test.txt][pseudo_fd=2]

Details about issue

In this case, The user's IAM role only has the AmazonS3ReadOnlyAccess permission, which can only mount and read the content in the Bucket. But in fact, the root user has read and write permissions to the successfully mounted directory.

Reproduce steps:

  1. cat ./test.txt

Read the data of the file correctly.

  1. echo qweqwe > ./test.txt

Data could not be written and an error was returned.

  1. cat ./test.txt

Unable to read the data of the file, it may be a cache error.

image

Expected behavior:
The original data will not be lost after the write fails. Or root does not have the write permission of the file when mounting.

However, if you change the > in step 2 to >>, then the correct data can still be read in step 3, but the user does not get the returned Operation not permitted error in step 2.

Originally created by @adamqqqplay on GitHub (Feb 22, 2023). Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/2120 When the user's IAM role does not have permission to write to the S3 Bucket, the file will lose its original data after overwriting. ### Additional Information #### Version of s3fs being used (`s3fs --version`) V1.91 (commit:f8a825e) #### Version of fuse being used (`pkg-config --modversion fuse`, `rpm -qi fuse` or `dpkg -s fuse`) 2.9.9 #### Kernel information (`uname -r`) 5.15.0-43-generic #### GNU/Linux Distribution, if applicable (`cat /etc/os-release`) PRETTY_NAME="Ubuntu 22.04.1 LTS" #### How to run s3fs, if applicable command line <!-- Executed command line or /etc/fastab entry --> ``` sudo s3fs elune-s3-test -o check_cache_dir_exist -o use_cache=~/test/s3fs/cache -o passwd_file=~/test/s3fs/s3key.txt -o allow_other -o auto_unmount -o entry_timeout=100000 -o attr_timeout=10000 -o dbglevel=info -f ./mnt ``` #### s3fs syslog messages (`grep s3fs /var/log/syslog`, `journalctl | grep s3fs`, or `s3fs outputs`) <!-- if you execute s3fs with dbglevel, curldbg option, you can get detail debug messages. --> ``` 2023-02-22T07:40:19.093Z [INF] s3fs.cpp:s3fs_open(2650): [path=/test.txt][flags=0x8000] 2023-02-22T07:40:19.093Z [INF] fdcache.cpp:GetFdEntity(484): [path=/test.txt][pseudo_fd=-1] 2023-02-22T07:40:19.093Z [INF] cache.cpp:DelStat(596): delete stat cache entry[path=/test.txt] 2023-02-22T07:40:19.093Z [INF] curl.cpp:HeadRequest(3295): [tpath=/test.txt] 2023-02-22T07:40:19.093Z [INF] curl.cpp:PreHeadRequest(3255): [tpath=/test.txt][bpath=][save=][sseckeypos=18446744073709551615] 2023-02-22T07:40:19.093Z [INF] curl_util.cpp:prepare_url(257): URL is https://s3-ap-southeast-1.amazonaws.com/elune-s3-test/test.txt 2023-02-22T07:40:19.093Z [INF] curl_util.cpp:prepare_url(290): URL changed is https://elune-s3-test.s3-ap-southeast-1.amazonaws.com/test.txt 2023-02-22T07:40:19.093Z [INF] curl.cpp:insertV4Headers(2888): computing signature [HEAD] [/test.txt] [] [] 2023-02-22T07:40:19.093Z [INF] curl_util.cpp:url_to_host(334): url is https://s3-ap-southeast-1.amazonaws.com 2023-02-22T07:40:19.173Z [INF] curl.cpp:RequestPerform(2516): HTTP response code 200 2023-02-22T07:40:19.173Z [INF] cache.cpp:AddStat(342): add stat cache entry[path=/test.txt] 2023-02-22T07:40:19.174Z [INF] fdcache_entity.cpp:SetMCtime(828): [path=/test.txt][physical_fd=25][mtime=1677050283][ctime=1677050283] 2023-02-22T07:40:19.174Z [INF] curl.cpp:GetObjectRequest(3640): [tpath=/test.txt][start=0][size=6] 2023-02-22T07:40:19.174Z [INF] curl.cpp:PreGetObjectRequest(3586): [tpath=/test.txt][start=0][size=6] 2023-02-22T07:40:19.174Z [INF] curl_util.cpp:prepare_url(257): URL is https://s3-ap-southeast-1.amazonaws.com/elune-s3-test/test.txt 2023-02-22T07:40:19.174Z [INF] curl_util.cpp:prepare_url(290): URL changed is https://elune-s3-test.s3-ap-southeast-1.amazonaws.com/test.txt 2023-02-22T07:40:19.175Z [INF] curl.cpp:GetObjectRequest(3659): downloading... [path=/test.txt][fd=25] 2023-02-22T07:40:19.175Z [INF] curl.cpp:insertV4Headers(2888): computing signature [GET] [/test.txt] [] [] 2023-02-22T07:40:19.175Z [INF] curl_util.cpp:url_to_host(334): url is https://s3-ap-southeast-1.amazonaws.com 2023-02-22T07:40:19.258Z [INF] curl.cpp:RequestPerform(2516): HTTP response code 206 2023-02-22T07:40:19.258Z [INF] s3fs.cpp:s3fs_flush(2816): [path=/test.txt][pseudo_fd=2] 2023-02-22T07:40:19.258Z [INF] fdcache_entity.cpp:RowFlush(1404): [tpath=][path=/test.txt][pseudo_fd=2][physical_fd=25] 2023-02-22T07:40:19.258Z [INF] cache.cpp:DelStat(596): delete stat cache entry[path=/test.txt] 2023-02-22T07:40:19.258Z [INF] s3fs.cpp:s3fs_release(2894): [path=/test.txt][pseudo_fd=2] 2023-02-22T07:40:19.258Z [INF] fdcache.cpp:GetFdEntity(484): [path=/test.txt][pseudo_fd=2] 2023-02-22T07:40:31.342Z [INF] s3fs.cpp:s3fs_open(2650): [path=/test.txt][flags=0x8201] 2023-02-22T07:40:31.342Z [INF] curl.cpp:HeadRequest(3295): [tpath=/test.txt] 2023-02-22T07:40:31.342Z [INF] curl.cpp:PreHeadRequest(3255): [tpath=/test.txt][bpath=][save=][sseckeypos=18446744073709551615] 2023-02-22T07:40:31.342Z [INF] curl_util.cpp:prepare_url(257): URL is https://s3-ap-southeast-1.amazonaws.com/elune-s3-test/test.txt 2023-02-22T07:40:31.342Z [INF] curl_util.cpp:prepare_url(290): URL changed is https://elune-s3-test.s3-ap-southeast-1.amazonaws.com/test.txt 2023-02-22T07:40:31.342Z [INF] curl.cpp:insertV4Headers(2888): computing signature [HEAD] [/test.txt] [] [] 2023-02-22T07:40:31.342Z [INF] curl_util.cpp:url_to_host(334): url is https://s3-ap-southeast-1.amazonaws.com 2023-02-22T07:40:31.690Z [INF] curl.cpp:RequestPerform(2516): HTTP response code 200 2023-02-22T07:40:31.690Z [INF] cache.cpp:AddStat(342): add stat cache entry[path=/test.txt] 2023-02-22T07:40:31.691Z [INF] fdcache_entity.cpp:SetMCtime(828): [path=/test.txt][physical_fd=25][mtime=1677050283][ctime=1677050283] 2023-02-22T07:40:31.691Z [INF] fdcache_entity.cpp:SetMCtime(828): [path=/test.txt][physical_fd=25][mtime=1677051631.691531478][ctime=1677051631.691531478] 2023-02-22T07:40:31.691Z [INF] fdcache_entity.cpp:RowFlush(1404): [tpath=/test.txt][path=/test.txt][pseudo_fd=2][physical_fd=25] 2023-02-22T07:40:31.691Z [INF] fdcache_entity.cpp:RowFlushMixMultipart(1629): [tpath=/test.txt][path=/test.txt][pseudo_fd=2][physical_fd=25] 2023-02-22T07:40:31.691Z [INF] curl.cpp:PutRequest(3445): [tpath=/test.txt] 2023-02-22T07:40:31.691Z [INF] curl_util.cpp:prepare_url(257): URL is https://s3-ap-southeast-1.amazonaws.com/elune-s3-test/test.txt 2023-02-22T07:40:31.691Z [INF] curl_util.cpp:prepare_url(290): URL changed is https://elune-s3-test.s3-ap-southeast-1.amazonaws.com/test.txt 2023-02-22T07:40:31.691Z [INF] curl.cpp:PutRequest(3573): uploading... [path=/test.txt][fd=25][size=0] 2023-02-22T07:40:31.691Z [INF] curl.cpp:insertV4Headers(2888): computing signature [PUT] [/test.txt] [] [e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855] 2023-02-22T07:40:31.691Z [INF] curl_util.cpp:url_to_host(334): url is https://s3-ap-southeast-1.amazonaws.com 2023-02-22T07:40:31.765Z [ERR] curl.cpp:RequestPerform(2563): HTTP response code 403, returning EPERM. Body Text: <?xml version="1.0" encoding="UTF-8"?> <Error><Code>AccessDenied</Code><Message>Access Denied</Message><RequestId>6CPX1XR60SF0M5A3</RequestId><HostId>kMkTGxn9xztyWyx10RHpoFSDTizU3cTrkPVVZ+M8mAzsp6AMipVg069vWwGwRL+AVuVChGbXt8s=</HostId></Error> 2023-02-22T07:40:31.765Z [ERR] s3fs.cpp:s3fs_open(2713): could not upload file(/test.txt): result=-1 2023-02-22T07:40:31.765Z [INF] cache.cpp:DelStat(596): delete stat cache entry[path=/test.txt] 2023-02-22T07:40:36.828Z [INF] s3fs.cpp:s3fs_open(2650): [path=/test.txt][flags=0x8000] 2023-02-22T07:40:36.828Z [INF] curl.cpp:HeadRequest(3295): [tpath=/test.txt] 2023-02-22T07:40:36.828Z [INF] curl.cpp:PreHeadRequest(3255): [tpath=/test.txt][bpath=][save=][sseckeypos=18446744073709551615] 2023-02-22T07:40:36.828Z [INF] curl_util.cpp:prepare_url(257): URL is https://s3-ap-southeast-1.amazonaws.com/elune-s3-test/test.txt 2023-02-22T07:40:36.828Z [INF] curl_util.cpp:prepare_url(290): URL changed is https://elune-s3-test.s3-ap-southeast-1.amazonaws.com/test.txt 2023-02-22T07:40:36.828Z [INF] curl.cpp:insertV4Headers(2888): computing signature [HEAD] [/test.txt] [] [] 2023-02-22T07:40:36.828Z [INF] curl_util.cpp:url_to_host(334): url is https://s3-ap-southeast-1.amazonaws.com 2023-02-22T07:40:36.904Z [INF] curl.cpp:RequestPerform(2516): HTTP response code 200 2023-02-22T07:40:36.904Z [INF] cache.cpp:AddStat(342): add stat cache entry[path=/test.txt] 2023-02-22T07:40:36.906Z [INF] fdcache_entity.cpp:SetMCtime(828): [path=/test.txt][physical_fd=25][mtime=1677050283][ctime=1677050283] 2023-02-22T07:40:36.906Z [INF] s3fs.cpp:s3fs_getattr(874): [path=/test.txt] 2023-02-22T07:40:36.906Z [INF] s3fs.cpp:s3fs_flush(2816): [path=/test.txt][pseudo_fd=2] 2023-02-22T07:40:36.906Z [INF] fdcache_entity.cpp:RowFlush(1404): [tpath=][path=/test.txt][pseudo_fd=2][physical_fd=25] 2023-02-22T07:40:36.906Z [INF] cache.cpp:DelStat(596): delete stat cache entry[path=/test.txt] 2023-02-22T07:40:36.906Z [INF] s3fs.cpp:s3fs_release(2894): [path=/test.txt][pseudo_fd=2] 2023-02-22T07:40:36.906Z [INF] fdcache.cpp:GetFdEntity(484): [path=/test.txt][pseudo_fd=2] ``` ### Details about issue <!-- Please describe the content of the issue in detail. --> In this case, The user's IAM role only has the AmazonS3ReadOnlyAccess permission, which can only mount and read the content in the Bucket. But in fact, the root user has read and write permissions to the successfully mounted directory. **Reproduce steps:** 1. `cat ./test.txt` Read the data of the file correctly. 2. `echo qweqwe > ./test.txt` Data could not be written and an error was returned. 3. `cat ./test.txt` Unable to read the data of the file, it may be a cache error. ![image](https://user-images.githubusercontent.com/29459113/220554697-a4b25ed5-4322-4c1f-9d46-1a6cfcb6c214.png) **Expected behavior:** The original data will not be lost after the write fails. Or root does not have the write permission of the file when mounting. However, if you change the `>` in step 2 to `>>`, then the correct data can still be read in step 3, but the user does not get the returned Operation not permitted error in step 2.
kerem closed this issue 2026-03-04 01:51:13 +03:00
kerem commented 2026-03-04 01:51:14 +03:00
Author
Owner
Copy link

@adamqqqplay commented on GitHub (Feb 27, 2023):

@ggtakec @gaul Hi, could you take a look please?

<!-- gh-comment-id:1445651888 --> @adamqqqplay commented on GitHub (Feb 27, 2023): @ggtakec @gaul Hi, could you take a look please?
kerem commented 2026-03-04 01:51:14 +03:00
Author
Owner
Copy link

@ggtakec commented on GitHub (Mar 12, 2023):

@adamqqqplay Sorry for my late reply.

I've tried a few pattern, but it's been hard to get exactly the same as your result.

However, I changed the state of the local cache manually(to wrong) and saw almost the same state.
Currently, s3fs is not clearing the local cache when an error occurs on the upload.

Below are my predictions:
When reading after an error, if the cache state(the cache of the object file itself and the state file of that cache) is consistent, I think that it reads from the local cache without reloading.

Your error appears to show the file contents, but you're probably loading 6 bytes filled with 0x00 data. (It becomes a hidden character on the console screen and looks like it doesn't display anything.)

In any case, the local cache (which is in an edited state) cannot be repaired if the upload fails, so we plan to fix it to clear the local cache.
I have submitted a corresponding PR #2127 for it, so if you can confirm it, please try it.

<!-- gh-comment-id:1465145882 --> @ggtakec commented on GitHub (Mar 12, 2023): @adamqqqplay Sorry for my late reply. I've tried a few pattern, but it's been hard to get exactly the same as your result. However, I changed the state of the local cache manually(to wrong) and saw almost the same state. Currently, s3fs is not clearing the local cache when an error occurs on the upload. Below are my predictions: When reading after an error, if the cache state(the cache of the object file itself and the state file of that cache) is consistent, I think that it reads from the local cache without reloading. Your error appears to show the file contents, but you're probably loading 6 bytes filled with 0x00 data. (It becomes a hidden character on the console screen and looks like it doesn't display anything.) In any case, the local cache (which is in an edited state) cannot be repaired if the upload fails, so we plan to fix it to clear the local cache. I have submitted a corresponding PR #2127 for it, so if you can confirm it, please try it.
kerem commented 2026-03-04 01:51:14 +03:00
Author
Owner
Copy link

@adamqqqplay commented on GitHub (Mar 13, 2023):

@adamqqqplay Sorry for my late reply.

I've tried a few pattern, but it's been hard to get exactly the same as your result.

However, I changed the state of the local cache manually(to wrong) and saw almost the same state. Currently, s3fs is not clearing the local cache when an error occurs on the upload.

Below are my predictions: When reading after an error, if the cache state(the cache of the object file itself and the state file of that cache) is consistent, I think that it reads from the local cache without reloading.

Your error appears to show the file contents, but you're probably loading 6 bytes filled with 0x00 data. (It becomes a hidden character on the console screen and looks like it doesn't display anything.)

In any case, the local cache (which is in an edited state) cannot be repaired if the upload fails, so we plan to fix it to clear the local cache. I have submitted a corresponding PR #2127 for it, so if you can confirm it, please try it.

@ggtakec Thanks, I believe your fix should do the trick, I'll test it right away.

In addition, I also proposed another fix method internally, which also deletes the wrong cache after the upload fails. The code is placed in my own repo: https://github.com/adamqqqplay/s3fs-fuse/tree/fix-cache-inconsistency , you could take a look when you are free. However, I think your fix is more general.

<!-- gh-comment-id:1465427210 --> @adamqqqplay commented on GitHub (Mar 13, 2023): > @adamqqqplay Sorry for my late reply. > > I've tried a few pattern, but it's been hard to get exactly the same as your result. > > However, I changed the state of the local cache manually(to wrong) and saw almost the same state. Currently, s3fs is not clearing the local cache when an error occurs on the upload. > > Below are my predictions: When reading after an error, if the cache state(the cache of the object file itself and the state file of that cache) is consistent, I think that it reads from the local cache without reloading. > > Your error appears to show the file contents, but you're probably loading 6 bytes filled with 0x00 data. (It becomes a hidden character on the console screen and looks like it doesn't display anything.) > > In any case, the local cache (which is in an edited state) cannot be repaired if the upload fails, so we plan to fix it to clear the local cache. I have submitted a corresponding PR #2127 for it, so if you can confirm it, please try it. @ggtakec Thanks, I believe your fix should do the trick, I'll test it right away. In addition, I also proposed another fix method internally, which also deletes the wrong cache after the upload fails. The code is placed in my own repo: https://github.com/adamqqqplay/s3fs-fuse/tree/fix-cache-inconsistency , you could take a look when you are free. However, I think your fix is more general.
kerem commented 2026-03-04 01:51:14 +03:00
Author
Owner
Copy link

@adamqqqplay commented on GitHub (Mar 13, 2023):

s3fs-fix-cache
@ggtakec Hi, I just tested your commit and it worked the same way as ours did, both fixed our previous issues. Thanks a lot!

<!-- gh-comment-id:1465457031 --> @adamqqqplay commented on GitHub (Mar 13, 2023): ![s3fs-fix-cache](https://user-images.githubusercontent.com/29459113/224601378-ee3775c4-b317-41f0-927a-aa65241989e7.jpg) @ggtakec Hi, I just tested your commit and it worked the same way as ours did, both fixed our previous issues. Thanks a lot!
kerem commented 2026-03-04 01:51:14 +03:00
Author
Owner
Copy link

@ggtakec commented on GitHub (Mar 13, 2023):

@adamqqqplay Thank you for your help.
I merged PR #2127.
If you still have a problem, please reopen or post a new issue.

<!-- gh-comment-id:1466054009 --> @ggtakec commented on GitHub (Mar 13, 2023): @adamqqqplay Thank you for your help. I merged PR #2127. If you still have a problem, please reopen or post a new issue.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
v1.97
v1.96
v1.95
v1.94
v1.93
v1.92
v1.91
v1.90
v1.89
v1.88
v1.87
v1.86
v1.85
v1.84
v1.83
v1.82
v1.81
v1.80
v1.79
v1.78
Pre-v1.78
v1.77
v1.76
v1.75
v1.74
Labels
Clear labels   
bug

   
bug

   
dataloss

   
duplicate

   
enhancement

   
feature request

   
help wanted

   
invalid

   
need info

   
performance

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
question

   
testing
No labels
bug
bug
dataloss
duplicate
enhancement
feature request
help wanted
invalid
need info
performance
pull-request
question
question
testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/s3fs-fuse#1080
No description provided.