[PR #1702] [MERGED] Remove unneeded volatile qualifiers #2127

New issue

Closed

opened 2026-03-04 02:03:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:03:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1702
Author: @gaul
Created: 6/27/2021
Status: ✅ Merged
Merged: 6/29/2021
Merged by: @ggtakec

Base: master ← Head: volatile

📝 Commits (1)

cde8345 Remove unneeded volatile qualifiers

📊 Changes

3 files changed (+4 additions, -3 deletions)

View changed files

📝 src/curl.h (+1 -1)
📝 src/fdcache_entity.cpp (+2 -1)
📝 src/fdcache_entity.h (+1 -1)

📄 Description

We should use proper locking instead. Specifically for
is_meta_pending this does not do what was intended due to the
read-modify-write of the member.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1702 **Author:** [@gaul](https://github.com/gaul) **Created:** 6/27/2021 **Status:** ✅ Merged **Merged:** 6/29/2021 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `volatile` --- ### 📝 Commits (1) - [`cde8345`](https://github.com/s3fs-fuse/s3fs-fuse/commit/cde834545e4c03764f8cc858336c01bfb66dcebc) Remove unneeded volatile qualifiers ### 📊 Changes **3 files changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.h` (+1 -1) 📝 `src/fdcache_entity.cpp` (+2 -1) 📝 `src/fdcache_entity.h` (+1 -1) </details> ### 📄 Description We should use proper locking instead. Specifically for `is_meta_pending` this does not do what was intended due to the read-modify-write of the member. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>