[PR #494] [MERGED] [fix] Fix endless sequential pagination #491

New issue

Closed

opened 2026-02-27 20:24:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/494
Author: @ramsayleung
Created: 9/13/2024
Status: ✅ Merged
Merged: 9/13/2024
Merged by: @ramsayleung

Base: master ← Head: ramsay/fix-endless-sequence

📝 Commits (2)

22efe77 Check both next page and items to avoid endless sequential pagination
447e519 Update CHANGELOG and fix the problem the pagination end early.

📊 Changes

2 files changed (+9 additions, -0 deletions)

View changed files

📝 CHANGELOG.md (+3 -0)
📝 src/clients/pagination/stream.rs (+6 -0)

📄 Description

Description

Fix endless sequential pagination issue caused by invalid data return from the Spotify server side.

Motivation and Context

The log dive and conclusion are posted in #492, check that issue for detail.

Dependencies

None

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How has this been tested?

All existing tests passed
Test with the example code posted in #492, the output becomes:

Items (blocking):
* Anomaly
* Not All The Beautiful Things
* Divide & Conquer (Remixes)
* Divide & Conquer

The pagination ends as expected.

Is this change properly documented?

Yes

Don't forget to add an entry to the CHANGELOG if necessary (new features, breaking changes, relevant internal improvements).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/494 **Author:** [@ramsayleung](https://github.com/ramsayleung) **Created:** 9/13/2024 **Status:** ✅ Merged **Merged:** 9/13/2024 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `ramsay/fix-endless-sequence` --- ### 📝 Commits (2) - [`22efe77`](https://github.com/ramsayleung/rspotify/commit/22efe7736cbdd589c2e06eb744128bfde841132c) Check both next page and items to avoid endless sequential pagination - [`447e519`](https://github.com/ramsayleung/rspotify/commit/447e5195b6faecb33d037e9ca8b6c186d9cba17f) Update CHANGELOG and fix the problem the pagination end early. ### 📊 Changes **2 files changed** (+9 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+3 -0) 📝 `src/clients/pagination/stream.rs` (+6 -0) </details> ### 📄 Description ## Description Fix endless sequential pagination issue caused by invalid data return from the Spotify server side. ## Motivation and Context The log dive and conclusion are posted in #492, check that issue for detail. ## Dependencies None ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How has this been tested? 1. All existing tests passed 2. Test with the example code posted in #492, the output becomes: ``` Items (blocking): * Anomaly * Not All The Beautiful Things * Divide & Conquer (Remixes) * Divide & Conquer ``` The pagination ends as expected. ## Is this change properly documented? Yes Don't forget to add an entry to the CHANGELOG if necessary (new features, breaking changes, relevant internal improvements). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>