[PR #497] [MERGED] Added support for multiple search and added some tests #494

Closed
opened 2026-02-27 20:24:56 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/497
Author: @jakin010
Created: 9/27/2024
Status: Merged
Merged: 9/30/2024
Merged by: @ramsayleung

Base: masterHead: master


📝 Commits (4)

  • f608623 Added support for multiple search and added some tests
  • 3e9c188 Changes in CHANGELOG
  • b1c7a81 Removed println
  • 48c081d Changed from vec to intoiter and changelog to version 0.14.0 and rust fmt

📊 Changes

4 files changed (+103 additions, -1 deletions)

View changed files

📝 CHANGELOG.md (+4 -0)
📝 rspotify-model/src/search.rs (+11 -0)
📝 src/clients/base.rs (+52 -1)
📝 tests/test_with_credential.rs (+36 -0)

📄 Description

Description

Their was no support for searching multiple types

Motivation and Context

#496

Type of change

  • [x ] New feature (non-breaking change which adds functionality)

How has this been tested?

  • [ z] test_search_album: testing normal search
  • [z ] test_search_multiple_types: testing if multiple types is returned

Is this change properly documented?

Yes


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/497 **Author:** [@jakin010](https://github.com/jakin010) **Created:** 9/27/2024 **Status:** ✅ Merged **Merged:** 9/30/2024 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`f608623`](https://github.com/ramsayleung/rspotify/commit/f60862331cf7bebf1cde67e8658a58cd0e771114) Added support for multiple search and added some tests - [`3e9c188`](https://github.com/ramsayleung/rspotify/commit/3e9c18842309b819b64a3246a32b0e788569e525) Changes in CHANGELOG - [`b1c7a81`](https://github.com/ramsayleung/rspotify/commit/b1c7a81eab937023c92fabaf30855a4845834520) Removed println - [`48c081d`](https://github.com/ramsayleung/rspotify/commit/48c081d1d06d00e911d48208c22ea06a850f769b) Changed from vec to intoiter and changelog to version 0.14.0 and rust fmt ### 📊 Changes **4 files changed** (+103 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+4 -0) 📝 `rspotify-model/src/search.rs` (+11 -0) 📝 `src/clients/base.rs` (+52 -1) 📝 `tests/test_with_credential.rs` (+36 -0) </details> ### 📄 Description ## Description Their was no support for searching multiple types ## Motivation and Context #496 ## Type of change - [x ] New feature (non-breaking change which adds functionality) ## How has this been tested? - [ z] test_search_album: testing normal search - [z ] test_search_multiple_types: testing if multiple types is returned ## Is this change properly documented? Yes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:24:56 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/rspotify#494
No description provided.