[PR #388] [MERGED] Remove rustc-serialize feature from chrono #428

New issue

Closed

opened 2026-02-27 20:24:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/388
Author: @aplanas
Created: 2/3/2023
Status: ✅ Merged
Merged: 2/4/2023
Merged by: @ramsayleung

Base: master ← Head: fix_rustc_serialize

📝 Commits (2)

c541e4e Remove rustc-serialize feature from chrono
7d41d56 Address clippy lints complains

📊 Changes

6 files changed (+9 additions, -9 deletions)

View changed files

📝 Cargo.toml (+1 -1)
📝 rspotify-http/src/common.rs (+2 -2)
📝 rspotify-http/src/reqwest.rs (+2 -2)
📝 rspotify-http/src/ureq.rs (+2 -2)
📝 rspotify-model/Cargo.toml (+1 -1)
📝 rspotify-model/src/custom_serde.rs (+1 -1)

📄 Description

Because rustc-serialize is considered insecured, and is using constructor that will be not compiled in future rustc, chrono dropped rustc-serialize in the main branch (future 0.5 release)

This patch remove this feature, to avoid the current compiler warning and prepare the work for the new chrono release.

Fix #387

Signed-off-by: Alberto Planas aplanas@suse.com

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/388 **Author:** [@aplanas](https://github.com/aplanas) **Created:** 2/3/2023 **Status:** ✅ Merged **Merged:** 2/4/2023 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `fix_rustc_serialize` --- ### 📝 Commits (2) - [`c541e4e`](https://github.com/ramsayleung/rspotify/commit/c541e4ee4991331b0c9c685057a3ab177de55235) Remove rustc-serialize feature from chrono - [`7d41d56`](https://github.com/ramsayleung/rspotify/commit/7d41d567ebe006b9c84e41f42d8a7bb482be7112) Address clippy lints complains ### 📊 Changes **6 files changed** (+9 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.toml` (+1 -1) 📝 `rspotify-http/src/common.rs` (+2 -2) 📝 `rspotify-http/src/reqwest.rs` (+2 -2) 📝 `rspotify-http/src/ureq.rs` (+2 -2) 📝 `rspotify-model/Cargo.toml` (+1 -1) 📝 `rspotify-model/src/custom_serde.rs` (+1 -1) </details> ### 📄 Description Because rustc-serialize is considered insecured, and is using constructor that will be not compiled in future rustc, chrono dropped rustc-serialize in the main branch (future 0.5 release) This patch remove this feature, to avoid the current compiler warning and prepare the work for the new chrono release. Fix #387 Signed-off-by: Alberto Planas <aplanas@suse.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>