[PR #303] [MERGED] Optional cursors #387

New issue

Closed

opened 2026-02-27 20:24:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/303
Author: @marioortizmanero
Created: 3/7/2022
Status: ✅ Merged
Merged: 3/8/2022
Merged by: @ramsayleung

Base: master ← Head: opt-cursors

📝 Commits (5)

802fc53 Optional cursors
4ace94f Add to CHANGELOG
fff7537 Fix clippy
4ade173 Merge branch 'master' into opt-cursors
cc57a40 fix changelog

📊 Changes

4 files changed (+6 additions, -5 deletions)

View changed files

📝 CHANGELOG.md (+3 -0)
📝 rspotify-model/src/page.rs (+1 -1)
📝 tests/test_with_credential.rs (+1 -1)
📝 tests/test_with_oauth.rs (+1 -3)

📄 Description

Description

This makes the cursors field optional. It also fixes a couple new clippy warnings.

Motivation and Context

See #301

Dependencies

None

Type of change

Please delete options that are not relevant.

Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

See #301. Furthermore, all tests continue to pass.

Is this change properly documented?

Yes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/303 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 3/7/2022 **Status:** ✅ Merged **Merged:** 3/8/2022 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `opt-cursors` --- ### 📝 Commits (5) - [`802fc53`](https://github.com/ramsayleung/rspotify/commit/802fc53c789c3568548f435dcdd6bf07eb1bd93e) Optional cursors - [`4ace94f`](https://github.com/ramsayleung/rspotify/commit/4ace94f0dd28ba82c58c37224e96c73625adcdcb) Add to CHANGELOG - [`fff7537`](https://github.com/ramsayleung/rspotify/commit/fff75373063d3cd5de0429519f7c3b5076126103) Fix clippy - [`4ade173`](https://github.com/ramsayleung/rspotify/commit/4ade173cc9d2440d14d89c6192122eea80ad1705) Merge branch 'master' into opt-cursors - [`cc57a40`](https://github.com/ramsayleung/rspotify/commit/cc57a4060763e758007ba655eece49a7fb0cf2cf) fix changelog ### 📊 Changes **4 files changed** (+6 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+3 -0) 📝 `rspotify-model/src/page.rs` (+1 -1) 📝 `tests/test_with_credential.rs` (+1 -1) 📝 `tests/test_with_oauth.rs` (+1 -3) </details> ### 📄 Description ## Description This makes the `cursors` field optional. It also fixes a couple new clippy warnings. ## Motivation and Context See #301 ## Dependencies None ## Type of change Please delete options that are not relevant. - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## How has this been tested? See #301. Furthermore, all tests continue to pass. ## Is this change properly documented? Yes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>