[PR #361] [MERGED] Update webapp example #413

New issue

Closed

opened 2026-02-27 20:24:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/361
Author: @ramsayleung
Created: 9/20/2022
Status: ✅ Merged
Merged: 12/27/2022
Merged by: @marioortizmanero

Base: master ← Head: ramsay_fix_failed_example

📝 Commits (10+)

14fed0c fix failed webapp example
bd0e5c8 delete unused imports
e80dbb0 update to 0.5rc
186e704 Add a new endpoints
9fea43f Add webapp CI
dee6753 update webapp ci default config
1df1eca update webapp ci default config
4da7c08 Remove working directory
8865dfa Use manifest instead of cwd
874891e optimize code by clippy's guide

📊 Changes

4 files changed (+241 additions, -90 deletions)

View changed files

➕ .github/workflows/webapp_ci.yml (+40 -0)
📝 examples/webapp/Cargo.toml (+5 -2)
📝 examples/webapp/src/main.rs (+193 -87)
📝 examples/webapp/templates/index.html.tera (+3 -1)

📄 Description

Description

Features:

Add token refreshing
Use the new API properly (at some point we do spotify.token = ..., we can surely avoid that).
Proper error handling? It has too many unwrap in my opinion.
Add string interpolation where possible
Include it in the CI somehow so that this doesn't happen anymore.

Motivation and Context

#324

Dependencies

log
env_log
cookie

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Is this change properly documented?

Not yet.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/361 **Author:** [@ramsayleung](https://github.com/ramsayleung) **Created:** 9/20/2022 **Status:** ✅ Merged **Merged:** 12/27/2022 **Merged by:** [@marioortizmanero](https://github.com/marioortizmanero) **Base:** `master` ← **Head:** `ramsay_fix_failed_example` --- ### 📝 Commits (10+) - [`14fed0c`](https://github.com/ramsayleung/rspotify/commit/14fed0c6781e3552ffbc8606a381baeb63a48d2b) fix failed webapp example - [`bd0e5c8`](https://github.com/ramsayleung/rspotify/commit/bd0e5c8dcf898229c82ebc15acdc58ba5d059eda) delete unused imports - [`e80dbb0`](https://github.com/ramsayleung/rspotify/commit/e80dbb07d3b84236dcd3e1832e8867a205ce85db) update to 0.5rc - [`186e704`](https://github.com/ramsayleung/rspotify/commit/186e704b1e8f258357449210c9a7c1d3e7fbcf03) Add a new endpoints - [`9fea43f`](https://github.com/ramsayleung/rspotify/commit/9fea43fff0ed257fb3fcd6d3ab9b9972e5ad579d) Add webapp CI - [`dee6753`](https://github.com/ramsayleung/rspotify/commit/dee6753282018129a0fb7418342011469b7d0e7b) update webapp ci default config - [`1df1eca`](https://github.com/ramsayleung/rspotify/commit/1df1eca6e563ee68f68b020a282baa51ba057b04) update webapp ci default config - [`4da7c08`](https://github.com/ramsayleung/rspotify/commit/4da7c08b1ca1f17e9838a51d6d1141ef3c1143e3) Remove working directory - [`8865dfa`](https://github.com/ramsayleung/rspotify/commit/8865dfa9b824e895c4cd82e933736bf0e7ff2427) Use manifest instead of cwd - [`874891e`](https://github.com/ramsayleung/rspotify/commit/874891e1a982b61da13df943cff83a53edce868c) optimize code by clippy's guide ### 📊 Changes **4 files changed** (+241 additions, -90 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/webapp_ci.yml` (+40 -0) 📝 `examples/webapp/Cargo.toml` (+5 -2) 📝 `examples/webapp/src/main.rs` (+193 -87) 📝 `examples/webapp/templates/index.html.tera` (+3 -1) </details> ### 📄 Description ## Description Features: - [x] Add token refreshing - [x] Use the new API properly (at some point we do `spotify.token = ...,` we can surely avoid that). - [x] Proper error handling? It has too many unwrap in my opinion. - [x] Add string interpolation where possible - [x] Include it in the CI somehow so that this doesn't happen anymore. ## Motivation and Context #324 ## Dependencies + log + env_log + cookie ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) ## How has this been tested? ## Is this change properly documented? Not yet. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>