[PR #222] [CLOSED] Fix feature conflicts #324

New issue

Closed

opened 2026-02-27 20:24:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/222
Author: @marioortizmanero
Created: 7/7/2021
Status: ❌ Closed

Base: master ← Head: fix-conflicts

📝 Commits (8)

47f1979 Clean up rspotify_http
122f981 Clients generic over the HTTP client
699c498 Some basic examples
da3bb25 Fix conflicting from_response
f2d83a6 This actually simplifies the CI
93d7ad6 Formatting
52119c0 Also simplify CI for docs
192c67e Document http-clients

📊 Changes

14 files changed (+84 additions, -65 deletions)

View changed files

📝 .github/workflows/ci.yml (+3 -8)
📝 Cargo.toml (+5 -0)
📝 examples/client_creds.rs (+2 -2)
➕ examples/http_clients.rs (+35 -0)
📝 examples/oauth_tokens.rs (+2 -2)
📝 examples/pagination_async.rs (+2 -2)
📝 rspotify-http/src/lib.rs (+2 -22)
📝 rspotify-http/src/reqwest.rs (+2 -2)
📝 rspotify-http/src/ureq.rs (+2 -2)
📝 src/auth_code.rs (+7 -7)
📝 src/auth_code_pkce.rs (+7 -7)
📝 src/client_creds.rs (+6 -6)
📝 src/clients/base.rs (+4 -3)
📝 src/clients/oauth.rs (+5 -2)

📄 Description

Closes #221

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/222 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 7/7/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-conflicts` --- ### 📝 Commits (8) - [`47f1979`](https://github.com/ramsayleung/rspotify/commit/47f1979180f64c96ad5b826c7dd14f6f10eb797d) Clean up rspotify_http - [`122f981`](https://github.com/ramsayleung/rspotify/commit/122f981ad50c224101cb57b82320fff86ea6736d) Clients generic over the HTTP client - [`699c498`](https://github.com/ramsayleung/rspotify/commit/699c4981e5e3066f6e4269198507265d7b165997) Some basic examples - [`da3bb25`](https://github.com/ramsayleung/rspotify/commit/da3bb25706201c35282ab242906c1a88a3d06b60) Fix conflicting from_response - [`f2d83a6`](https://github.com/ramsayleung/rspotify/commit/f2d83a6eb5d534bab8f2b365c950cdf29d294ad1) This actually simplifies the CI - [`93d7ad6`](https://github.com/ramsayleung/rspotify/commit/93d7ad64c155c1786e7c7f129ebcff3835789b5e) Formatting - [`52119c0`](https://github.com/ramsayleung/rspotify/commit/52119c038e992661e34c3db9e55b4c4d4228ed5d) Also simplify CI for docs - [`192c67e`](https://github.com/ramsayleung/rspotify/commit/192c67e472a2534f3d99f8b6e79970c022126cc8) Document http-clients ### 📊 Changes **14 files changed** (+84 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+3 -8) 📝 `Cargo.toml` (+5 -0) 📝 `examples/client_creds.rs` (+2 -2) ➕ `examples/http_clients.rs` (+35 -0) 📝 `examples/oauth_tokens.rs` (+2 -2) 📝 `examples/pagination_async.rs` (+2 -2) 📝 `rspotify-http/src/lib.rs` (+2 -22) 📝 `rspotify-http/src/reqwest.rs` (+2 -2) 📝 `rspotify-http/src/ureq.rs` (+2 -2) 📝 `src/auth_code.rs` (+7 -7) 📝 `src/auth_code_pkce.rs` (+7 -7) 📝 `src/client_creds.rs` (+6 -6) 📝 `src/clients/base.rs` (+4 -3) 📝 `src/clients/oauth.rs` (+5 -2) </details> ### 📄 Description Closes #221 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>