[PR #201] [MERGED] Finish the pagination implementation #310

New issue

Closed

opened 2026-02-27 20:24:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/201
Author: @marioortizmanero
Created: 4/19/2021
Status: ✅ Merged
Merged: 4/22/2021
Merged by: @ramsayleung

Base: master ← Head: finish-pagination

📝 Commits (10+)

9191013 change naming to _manual
6733e08 base implementations
4ef0fa8 docs improvements and more progress
d9ffe17 manually implemented all the endpoints
8a95212 fix docs
a68137b fix tests & examples
60f5610 fix changelog
b0a4bf7 add pagination_chunks
2e5da23 mention pagination_chunks in the changelog
42cabe7 use pagination_chunks in tests and fix generics

📊 Changes

9 files changed (+280 additions, -94 deletions)

View changed files

📝 CHANGELOG.md (+6 -1)
📝 examples/pagination_async.rs (+2 -2)
📝 examples/pagination_manual.rs (+1 -1)
📝 examples/pagination_sync.rs (+1 -1)
📝 src/client.rs (+242 -46)
📝 src/pagination/iter.rs (+2 -6)
📝 src/pagination/stream.rs (+4 -4)
📝 tests/test_with_credential.rs (+11 -22)
📝 tests/test_with_oauth.rs (+11 -11)

📄 Description

Description

This finishes what was left at #166

Closes #124

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/201 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 4/19/2021 **Status:** ✅ Merged **Merged:** 4/22/2021 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `finish-pagination` --- ### 📝 Commits (10+) - [`9191013`](https://github.com/ramsayleung/rspotify/commit/9191013f6eb0f63c7f76b03992137149a77be06b) change naming to _manual - [`6733e08`](https://github.com/ramsayleung/rspotify/commit/6733e0871f15cc7e4180a8df72bb507c49c606a3) base implementations - [`4ef0fa8`](https://github.com/ramsayleung/rspotify/commit/4ef0fa871b029c710d3964acbc616705effa5e9f) docs improvements and more progress - [`d9ffe17`](https://github.com/ramsayleung/rspotify/commit/d9ffe17c66e8193c613f5a92146c5eb6cf024582) manually implemented all the endpoints - [`8a95212`](https://github.com/ramsayleung/rspotify/commit/8a95212261f416b969d4fb11b3a484826bdba967) fix docs - [`a68137b`](https://github.com/ramsayleung/rspotify/commit/a68137bd8058616cfcdb7c38d7bb7e20126e2693) fix tests & examples - [`60f5610`](https://github.com/ramsayleung/rspotify/commit/60f561000ffc63fec590783f31fea799cc7c33ba) fix changelog - [`b0a4bf7`](https://github.com/ramsayleung/rspotify/commit/b0a4bf7732fac510e606ce529c9c44d962656980) add pagination_chunks - [`2e5da23`](https://github.com/ramsayleung/rspotify/commit/2e5da23b781c696bf8c7ce7fb70cfee82536d233) mention pagination_chunks in the changelog - [`42cabe7`](https://github.com/ramsayleung/rspotify/commit/42cabe711883de1e3754d4d793ab498468986301) use pagination_chunks in tests and fix generics ### 📊 Changes **9 files changed** (+280 additions, -94 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+6 -1) 📝 `examples/pagination_async.rs` (+2 -2) 📝 `examples/pagination_manual.rs` (+1 -1) 📝 `examples/pagination_sync.rs` (+1 -1) 📝 `src/client.rs` (+242 -46) 📝 `src/pagination/iter.rs` (+2 -6) 📝 `src/pagination/stream.rs` (+4 -4) 📝 `tests/test_with_credential.rs` (+11 -22) 📝 `tests/test_with_oauth.rs` (+11 -11) </details> ### 📄 Description ## Description This finishes what was left at #166 Closes #124 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>