starred/rspotify
1
0
Fork 0
mirror of https://github.com/ramsayleung/rspotify.git synced 2026-04-26 07:55:55 +03:00
Code Issues 15 Projects Releases 5 Packages Wiki Activity

[GH-ISSUE #511] No way to create AuthCodePkceSpotify from token with config #166

New issue
Closed
opened 2026-02-27 20:23:31 +03:00 by kerem · 2 comments
kerem commented 2026-02-27 20:23:31 +03:00
Owner
Copy link

Originally created by @gdesmott on GitHub (Dec 28, 2024).
Original GitHub issue: https://github.com/ramsayleung/rspotify/issues/511

There is currently no way to create AuthCodePkceSpotify with a custom config.

Is there any reason to not have AuthCodePkceSpotify::from_token_with_config() as there is for AuthCodeSpotify?

Originally created by @gdesmott on GitHub (Dec 28, 2024). Original GitHub issue: https://github.com/ramsayleung/rspotify/issues/511 There is currently no way to create `AuthCodePkceSpotify` with a custom config. Is there any reason to not have `AuthCodePkceSpotify::from_token_with_config()` as there is for `AuthCodeSpotify`?
kerem 2026-02-27 20:23:31 +03:00
kerem commented 2026-02-27 20:23:32 +03:00
Author
Owner
Copy link

@gdesmott commented on GitHub (Dec 29, 2024):

I think we need this to be able to refresh an expired cached token, see https://github.com/ramsayleung/rspotify/pull/512

<!-- gh-comment-id:2564770730 --> @gdesmott commented on GitHub (Dec 29, 2024): I think we need this to be able to refresh an expired cached token, see https://github.com/ramsayleung/rspotify/pull/512
kerem commented 2026-02-27 20:23:32 +03:00
Author
Owner
Copy link

@ramsayleung commented on GitHub (Dec 29, 2024):

The AuthCodePkceSpotify implementation was contributed by another maintainer, so I don't have full context on the reasoning behind not including a from_token_with_config() method, my intuition is he might just miss the requirement of the function.

<!-- gh-comment-id:2564810970 --> @ramsayleung commented on GitHub (Dec 29, 2024): The `AuthCodePkceSpotify` implementation was contributed by another maintainer, so I don't have full context on the reasoning behind not including a `from_token_with_config()` method, my intuition is he might just miss the requirement of the function.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
ramsay/upgrade-0.16.1
dependabot/cargo/sha2-0.11.0
ramsay/upgrade-to-v0.16
ramsay/deprecate-removed-renamed-field
ramsay/migrate-to-new-endpoint
ramsay/deprecate-removed-endpoints
dependabot/cargo/strum-0.28.0
dependabot/cargo/reqwest-middleware-0.5.1
dependabot/cargo/reqwest-0.13.1
ramsay/upgrade-to-0.15.3
ramsay/upgrade-to-0.15.2
dependabot/cargo/ureq-3.1.2
ramsay/upgrade-dependencies
ramsay/upgrade-to-0.15.1
ramsay/fix-malformed-json
ramsay/upgrade-to-v0.15.0
ramsay/allow-enum-unknown-variant
ramsay/upgrade-to-0.14
ramsay/add_tcplistern_for_callback
ramsay/fix-clippy-error
ramsay/update-doc
ramsay/fix-endless-sequence
ramsay/publish-crate-workflow-test
ramsay/fix-pkce-refresh-token
ramsay/pkce_auth_refresh_token
ramsay_add_test_for_collectionyourepisodes
better-webapp
ramsay_fix_token_expired
percent-search
refresh_token_rwlock
ramsay_convert_result_inside_endpoint
streaming
v0.16.1
v0.16.0
v0.15.3
v0.15.2
v0.15.1
v0.15.0
v0.14.0
v0.13.3
v0.13.2
v0.13.1
v0.13.0
v0.12.0
v0.11.7
v0.11.6
v0.10.0
v0.11.5
v0.11.5.0
v0.11.4
v0.11.3
v0.11.2
v0.11.1
v0.11.0
v0.11.5.1
v0.9
v0.9-alpha
Labels
Clear labels   
Stale

   
bug

   
discussion

   
enhancement

   
good first issue

   
good first issue

   
help wanted

   
pull-request

Mirrored from GitHub Pull Request

  
question
No labels
Stale
bug
discussion
enhancement
good first issue
good first issue
help wanted
pull-request
question
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/rspotify#166
No description provided.