[GH-ISSUE #407] Incorrect type for playlist position #130

New issue

Closed

opened 2026-02-27 20:23:18 +03:00 by kerem · 3 comments

kerem commented

2026-02-27 20:23:18 +03:00

Owner

Originally created by @hrkfdn on GitHub (Apr 29, 2023).
Original GitHub issue: https://github.com/ramsayleung/rspotify/issues/407

Describe the bug
With #375 some types were changed from integers to chrono::Duration. While this is a great change, I believe a mistake snuck in:

github.com/ramsayleung/rspotify@0a6c136b56/src/clients/oauth.rs (L292-L315)

Expected behavior

The position in this method is a playlist position and not time related. I don't think chrono::Duration is appropriate here. What do you think?

Originally created by @hrkfdn on GitHub (Apr 29, 2023). Original GitHub issue: https://github.com/ramsayleung/rspotify/issues/407 **Describe the bug** With #375 some types were changed from integers to `chrono::Duration`. While this is a great change, I believe a mistake snuck in: https://github.com/ramsayleung/rspotify/blob/0a6c136b56ab1e882e26ac536a44c405a37706e4/src/clients/oauth.rs#L292-L315 **Expected behavior** The position in this method is a playlist position and not time related. I don't think `chrono::Duration` is appropriate here. What do you think?

kerem

2026-02-27 20:23:18 +03:00

closed this issue
added the
help wanted

bug
labels

kerem commented

2026-02-27 20:23:18 +03:00

Author

Owner

@ramsayleung commented on GitHub (May 4, 2023):

Agree, it should be an integer instead of Duration, because it's a zero-based index. I would like to fix it as soon as possible.

@ramsayleung commented on GitHub (May 4, 2023): Agree, it should be an integer instead of `Duration`, because it's a zero-based index. I would like to fix it as soon as possible.

kerem commented

2026-02-27 20:23:18 +03:00

Author

Owner

@ramsayleung commented on GitHub (May 22, 2023):

This problem has been fixed, the type of position rollback to Option<u32>

@ramsayleung commented on GitHub (May 22, 2023): This problem has been fixed, the type of `position` rollback to `Option<u32>`

kerem commented

2026-02-27 20:23:18 +03:00

Author

Owner

@hrkfdn commented on GitHub (May 22, 2023):

Hooray, thanks! 🎉

@hrkfdn commented on GitHub (May 22, 2023): Hooray, thanks! :tada: