[GH-ISSUE #39] Fix NameError in dataflow validation error logging #6

Closed
opened 2026-03-02 04:07:46 +03:00 by kerem · 1 comment
Owner

Originally created by @gadievron on GitHub (Dec 22, 2025).
Original GitHub issue: https://github.com/gadievron/raptor/issues/39

Problem

Line 213 in packages/codeql/dataflow_validator.py references undefined variable sink.label instead of dataflow.sink.label, causing NameError during error logging and masking the original validation error.

Impact

  • Secondary error masks primary validation error
  • Error logging fails when it's most needed

Fix

- logger.error(f"Dataflow path validation failed: {sink.label}")
+ logger.error(f"Dataflow path validation failed: {dataflow.sink.label}")

File: packages/codeql/dataflow_validator.py:213

Type

  • Bug fix (non-breaking)
  • Bug #1 from internal analysis
  • Multi-agent validated
Originally created by @gadievron on GitHub (Dec 22, 2025). Original GitHub issue: https://github.com/gadievron/raptor/issues/39 ## Problem Line 213 in `packages/codeql/dataflow_validator.py` references undefined variable `sink.label` instead of `dataflow.sink.label`, causing NameError during error logging and masking the original validation error. ## Impact - Secondary error masks primary validation error - Error logging fails when it's most needed ## Fix ```diff - logger.error(f"Dataflow path validation failed: {sink.label}") + logger.error(f"Dataflow path validation failed: {dataflow.sink.label}") ``` **File:** `packages/codeql/dataflow_validator.py:213` ## Type - Bug fix (non-breaking) ## Related - Bug #1 from internal analysis - Multi-agent validated
kerem 2026-03-02 04:07:46 +03:00
Author
Owner

@gadievron commented on GitHub (Dec 22, 2025):

Fixed in PR #45

<!-- gh-comment-id:3684216844 --> @gadievron commented on GitHub (Dec 22, 2025): Fixed in PR #45
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/raptor#6
No description provided.