[PR #86] [MERGED] Fix error when activity is provided #86

New issue

Closed

opened 2026-02-28 01:19:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:19:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tr4nt0r/python-xbox/pull/86
Author: @tomballgithub
Created: 1/22/2026
Status: ✅ Merged
Merged: 1/22/2026
Merged by: @tr4nt0r

Base: main ← Head: fix_err

📝 Commits (5)

b0ce92c Fix error when activity is provided, because it is a Dict not a List
baea0e4 Add test to verify activity response doesn't break pydantic check
1293a18 Merge pull request #1 from tr4nt0r/main
ce03cdb Use responses file to store json test information
aa18143 Add additional json test file

📊 Changes

3 files changed (+35 additions, -1 deletions)

View changed files

📝 src/pythonxbox/api/provider/presence/models.py (+1 -1)
➕ tests/data/responses/presence_activity.json (+20 -0)
📝 tests/test_presence.py (+14 -0)

📄 Description

When activity is returned, it is causing an error because it is a dict not a list.

This fixes: #85

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tr4nt0r/python-xbox/pull/86 **Author:** [@tomballgithub](https://github.com/tomballgithub) **Created:** 1/22/2026 **Status:** ✅ Merged **Merged:** 1/22/2026 **Merged by:** [@tr4nt0r](https://github.com/tr4nt0r) **Base:** `main` ← **Head:** `fix_err` --- ### 📝 Commits (5) - [`b0ce92c`](https://github.com/tr4nt0r/python-xbox/commit/b0ce92c15bffef3dae55cc6e59dae71f2c25d815) Fix error when activity is provided, because it is a Dict not a List - [`baea0e4`](https://github.com/tr4nt0r/python-xbox/commit/baea0e4a5acf88bbdb237885b93143c5a971a18b) Add test to verify activity response doesn't break pydantic check - [`1293a18`](https://github.com/tr4nt0r/python-xbox/commit/1293a182f6c7ca681cbbcd7f3b27a44d06b8e982) Merge pull request #1 from tr4nt0r/main - [`ce03cdb`](https://github.com/tr4nt0r/python-xbox/commit/ce03cdba82c10b2bd28796dc84a303da0da16bea) Use responses file to store json test information - [`aa18143`](https://github.com/tr4nt0r/python-xbox/commit/aa1814389b7ddfe910458e954c6a4ae32daf10c8) Add additional json test file ### 📊 Changes **3 files changed** (+35 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/pythonxbox/api/provider/presence/models.py` (+1 -1) ➕ `tests/data/responses/presence_activity.json` (+20 -0) 📝 `tests/test_presence.py` (+14 -0) </details> ### 📄 Description When activity is returned, it is causing an error because it is a dict not a list. This fixes: #85 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>