[PR #594] [MERGED] Added LastFM support #611

New issue

Closed

opened 2026-02-28 14:33:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/594
Author: @marcfusch
Created: 4/8/2025
Status: ✅ Merged
Merged: 4/17/2025
Merged by: @jacksongoode

Base: main ← Head: lastfm_wip

📝 Commits (10+)

c1574fc stuff
1fa668d bof
a0f7337 its working
3f29d27 now playing currently works perfectly
df7017b scrobbling and now playing works !
c15497f fixed csroblling problems while song changes
58b0560 cleanup of code and added comments
8c9925d changed scrobbler icon in the preferences menu
261f132 small cleanup (for tarrak only)
490aed3 Cleanup and integration into account tab

📊 Changes

21 files changed (+1488 additions, -613 deletions)

View changed files

📝 .github/ISSUE_TEMPLATE/bug_report.md (+5 -5)
📝 .github/ISSUE_TEMPLATE/feature_request.md (+3 -4)
📝 .github/workflows/build.yml (+1 -1)
📝 .pkg/APPIMAGE/pkg2appimage-ingredients.yml (+1 -1)
📝 .rustfmt.toml (+1 -1)
📝 Cargo.lock (+665 -395)
📝 README.md (+2 -2)
📝 psst-core/Cargo.toml (+1 -0)
📝 psst-core/src/error.rs (+17 -0)
➕ psst-core/src/lastfm.rs (+95 -0)
📝 psst-core/src/lib.rs (+2 -1)
📝 psst-core/src/oauth.rs (+115 -31)
📝 psst-gui/Cargo.toml (+1 -0)
📝 psst-gui/src/controller/playback.rs (+109 -8)
📝 psst-gui/src/data/config.rs (+27 -1)
📝 psst-gui/src/data/mod.rs (+14 -6)
📝 psst-gui/src/delegate.rs (+25 -41)
📝 psst-gui/src/main.rs (+5 -1)
📝 psst-gui/src/ui/preferences.rs (+384 -108)
📝 psst-gui/src/widget/icons.rs (+8 -0)

...and 1 more files

📄 Description

Hello, (this is a PR in response to #424)
I have made the required modifications to the codebase in order to plug psst into the rustfm-scrobbler-proxy library.
I have created a new lastfm.rs file that contains the necessary functions that communicates with the api library.
The necessary functions are called from within the controller/playback.rs file.
I have also added a new tab into the preferences menu that requires api key, api secret, username and password from your lastfm account.
The two firsts can be obtained here: https://www.last.fm/api/account/create
Please guide me through (if necessary) to make the final modifications.
Thanks!
Capture d’écran 2025-04-08 à 22 12 24

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/594 **Author:** [@marcfusch](https://github.com/marcfusch) **Created:** 4/8/2025 **Status:** ✅ Merged **Merged:** 4/17/2025 **Merged by:** [@jacksongoode](https://github.com/jacksongoode) **Base:** `main` ← **Head:** `lastfm_wip` --- ### 📝 Commits (10+) - [`c1574fc`](https://github.com/jpochyla/psst/commit/c1574fc1b9a1a9ea1883d713c7857556a4fe3628) stuff - [`1fa668d`](https://github.com/jpochyla/psst/commit/1fa668d54ce5acb03830bac1be7d895d53b395ab) bof - [`a0f7337`](https://github.com/jpochyla/psst/commit/a0f73373e5702fc701308144a5e770af7b491c8a) its working - [`3f29d27`](https://github.com/jpochyla/psst/commit/3f29d270fe3458763b5de41f572d4abd26488fb3) now playing currently works perfectly - [`df7017b`](https://github.com/jpochyla/psst/commit/df7017be003968739662b1b03453f7f6558f8f54) scrobbling and now playing works ! - [`c15497f`](https://github.com/jpochyla/psst/commit/c15497f5410352baae52b430c0d88d54bdc535dd) fixed csroblling problems while song changes - [`58b0560`](https://github.com/jpochyla/psst/commit/58b05603657455f59d2a4e8762d2c59313a6a75c) cleanup of code and added comments - [`8c9925d`](https://github.com/jpochyla/psst/commit/8c9925d41881422f20203589d58027f012201da0) changed scrobbler icon in the preferences menu - [`261f132`](https://github.com/jpochyla/psst/commit/261f132171caebc15a841cc8b9d2d0221b748d82) small cleanup (for tarrak only) - [`490aed3`](https://github.com/jpochyla/psst/commit/490aed3c0a52d80010343ffdb55feda15c796b42) Cleanup and integration into account tab ### 📊 Changes **21 files changed** (+1488 additions, -613 deletions) <details> <summary>View changed files</summary> 📝 `.github/ISSUE_TEMPLATE/bug_report.md` (+5 -5) 📝 `.github/ISSUE_TEMPLATE/feature_request.md` (+3 -4) 📝 `.github/workflows/build.yml` (+1 -1) 📝 `.pkg/APPIMAGE/pkg2appimage-ingredients.yml` (+1 -1) 📝 `.rustfmt.toml` (+1 -1) 📝 `Cargo.lock` (+665 -395) 📝 `README.md` (+2 -2) 📝 `psst-core/Cargo.toml` (+1 -0) 📝 `psst-core/src/error.rs` (+17 -0) ➕ `psst-core/src/lastfm.rs` (+95 -0) 📝 `psst-core/src/lib.rs` (+2 -1) 📝 `psst-core/src/oauth.rs` (+115 -31) 📝 `psst-gui/Cargo.toml` (+1 -0) 📝 `psst-gui/src/controller/playback.rs` (+109 -8) 📝 `psst-gui/src/data/config.rs` (+27 -1) 📝 `psst-gui/src/data/mod.rs` (+14 -6) 📝 `psst-gui/src/delegate.rs` (+25 -41) 📝 `psst-gui/src/main.rs` (+5 -1) 📝 `psst-gui/src/ui/preferences.rs` (+384 -108) 📝 `psst-gui/src/widget/icons.rs` (+8 -0) _...and 1 more files_ </details> ### 📄 Description Hello, (this is a PR in response to #424) I have made the required modifications to the codebase in order to plug psst into the rustfm-scrobbler-proxy library. I have created a new lastfm.rs file that contains the necessary functions that communicates with the api library. The necessary functions are called from within the controller/playback.rs file. I have also added a new tab into the preferences menu that requires api key, api secret, username and password from your lastfm account. The two firsts can be obtained here: https://www.last.fm/api/account/create Please guide me through (if necessary) to make the final modifications. Thanks! <img width="512" alt="Capture d’écran 2025-04-08 à 22 12 24" src="https://github.com/user-attachments/assets/85401ee2-1208-4fdb-a7e8-fd98989f1838" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>