mirror of
https://github.com/jpochyla/psst.git
synced 2026-04-27 07:25:52 +03:00
[PR #80] [MERGED] More visible active track #424
Labels
No labels
api
bug
build
documentation
duplicate
enhancement
good first issue
help wanted
idea
invalid
linux
lowprio
macos
pull-request
upstream
windows
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/psst#424
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jpochyla/psst/pull/80
Author: @Kethku
Created: 7/17/2021
Status: ✅ Merged
Merged: 7/18/2021
Merged by: @jpochyla
Base:
master← Head:more-visible-active-track📝 Commits (2)
4d038bedon't show console on windows machines when running release builds0fbdd13make active track a little more visible📊 Changes
4 files changed (+21 additions, -1 deletions)
View changed files
📝
psst-gui/src/main.rs(+1 -0)📝
psst-gui/src/ui/theme.rs(+3 -0)📝
psst-gui/src/ui/track.rs(+1 -0)📝
psst-gui/src/widget/link.rs(+16 -1)📄 Description
Addresses https://github.com/jpochyla/psst/issues/76 by adding a new link background state for when the link is active. I added a function to link which takes a predicate and a background color to render when the predicate returns true.
Dark Mode:

Light Mode:

Note: I noticed that light mode selection theme is a bit too subtle, so I had to boost the alpha for light mode a bit more than I did for dark mode.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.