[PR #80] [MERGED] More visible active track #424

Closed
opened 2026-02-28 14:32:57 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/80
Author: @Kethku
Created: 7/17/2021
Status: Merged
Merged: 7/18/2021
Merged by: @jpochyla

Base: masterHead: more-visible-active-track


📝 Commits (2)

  • 4d038be don't show console on windows machines when running release builds
  • 0fbdd13 make active track a little more visible

📊 Changes

4 files changed (+21 additions, -1 deletions)

View changed files

📝 psst-gui/src/main.rs (+1 -0)
📝 psst-gui/src/ui/theme.rs (+3 -0)
📝 psst-gui/src/ui/track.rs (+1 -0)
📝 psst-gui/src/widget/link.rs (+16 -1)

📄 Description

Addresses https://github.com/jpochyla/psst/issues/76 by adding a new link background state for when the link is active. I added a function to link which takes a predicate and a background color to render when the predicate returns true.

Dark Mode:
image

Light Mode:
image

Note: I noticed that light mode selection theme is a bit too subtle, so I had to boost the alpha for light mode a bit more than I did for dark mode.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/80 **Author:** [@Kethku](https://github.com/Kethku) **Created:** 7/17/2021 **Status:** ✅ Merged **Merged:** 7/18/2021 **Merged by:** [@jpochyla](https://github.com/jpochyla) **Base:** `master` ← **Head:** `more-visible-active-track` --- ### 📝 Commits (2) - [`4d038be`](https://github.com/jpochyla/psst/commit/4d038be8dac4401b2c97eebfdbe3ec02734724fe) don't show console on windows machines when running release builds - [`0fbdd13`](https://github.com/jpochyla/psst/commit/0fbdd1380db6baed6235254ff6f4bafc99ed7d93) make active track a little more visible ### 📊 Changes **4 files changed** (+21 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `psst-gui/src/main.rs` (+1 -0) 📝 `psst-gui/src/ui/theme.rs` (+3 -0) 📝 `psst-gui/src/ui/track.rs` (+1 -0) 📝 `psst-gui/src/widget/link.rs` (+16 -1) </details> ### 📄 Description Addresses https://github.com/jpochyla/psst/issues/76 by adding a new link background state for when the link is active. I added a function to link which takes a predicate and a background color to render when the predicate returns true. Dark Mode: ![image](https://user-images.githubusercontent.com/3323631/126051602-349b6f52-ba19-412f-9bc0-bf1b68040c1e.png) Light Mode: ![image](https://user-images.githubusercontent.com/3323631/126051625-4b85773f-0b60-40b8-8379-2a91cc723b29.png) Note: I noticed that light mode selection theme is a bit too subtle, so I had to boost the alpha for light mode a bit more than I did for dark mode. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:32:57 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/psst#424
No description provided.