[PR #498] [MERGED] UI cleanup for save track icon #567

New issue

Closed

opened 2026-02-28 14:33:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/498
Author: @jacksongoode
Created: 7/11/2024
Status: ✅ Merged
Merged: 8/4/2024
Merged by: @jacksongoode

Base: master ← Head: jackson/cleanup

📝 Commits (6)

3fc7c8d Cleanup - new icons, new location, small fixes
2dc05c6 Click whole widget
6616870 Revert
fb9140b Fix capitalization of some menu items
b3830e9 Cleanup
79bc214 Just switch icon

📊 Changes

6 files changed (+46 additions, -45 deletions)

View changed files

📝 psst-gui/src/ui/album.rs (+2 -2)
📝 psst-gui/src/ui/episode.rs (+1 -1)
📝 psst-gui/src/ui/playback.rs (+2 -2)
📝 psst-gui/src/ui/track.rs (+10 -10)
📝 psst-gui/src/webapi/client.rs (+24 -24)
📝 psst-gui/src/widget/icons.rs (+7 -6)

📄 Description

This PR:

Fix some minor string capitalization consistency issues
Switches the heart to an add icon (consistent with Spotify)
Adds the icon to the row below the duration (to save save horizontal space and prevent reflow when tracks load)

Here's what it would look like:

However, this introduces an issue where clicking on the save icon actually triggers the parents play action - so that would need to be fixed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/498 **Author:** [@jacksongoode](https://github.com/jacksongoode) **Created:** 7/11/2024 **Status:** ✅ Merged **Merged:** 8/4/2024 **Merged by:** [@jacksongoode](https://github.com/jacksongoode) **Base:** `master` ← **Head:** `jackson/cleanup` --- ### 📝 Commits (6) - [`3fc7c8d`](https://github.com/jpochyla/psst/commit/3fc7c8d083c6c34eb8ba115b4a135596c8459e84) Cleanup - new icons, new location, small fixes - [`2dc05c6`](https://github.com/jpochyla/psst/commit/2dc05c67785cf5c91f59d4d2098df55d3519bf6b) Click whole widget - [`6616870`](https://github.com/jpochyla/psst/commit/66168709e29a505930f518daa4dc4211759d29ed) Revert - [`fb9140b`](https://github.com/jpochyla/psst/commit/fb9140b988570fdef5eeb4db4f024394333b42dd) Fix capitalization of some menu items - [`b3830e9`](https://github.com/jpochyla/psst/commit/b3830e9c123ef4d3fcaf5f3fbc8777fb4febb519) Cleanup - [`79bc214`](https://github.com/jpochyla/psst/commit/79bc214068d5616779aab86a6f452efb93ff78fb) Just switch icon ### 📊 Changes **6 files changed** (+46 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `psst-gui/src/ui/album.rs` (+2 -2) 📝 `psst-gui/src/ui/episode.rs` (+1 -1) 📝 `psst-gui/src/ui/playback.rs` (+2 -2) 📝 `psst-gui/src/ui/track.rs` (+10 -10) 📝 `psst-gui/src/webapi/client.rs` (+24 -24) 📝 `psst-gui/src/widget/icons.rs` (+7 -6) </details> ### 📄 Description This PR: - Fix some minor string capitalization consistency issues - Switches the heart to an add icon (consistent with Spotify) - Adds the icon to the row below the duration (to save save horizontal space and prevent reflow when tracks load) Here's what it would look like: <img width="390" alt="image" src="https://github.com/user-attachments/assets/28d66467-16d7-4284-a496-49f8f3031e88"> <img width="550" alt="image" src="https://github.com/user-attachments/assets/0079e1aa-c2da-41d9-9ba0-0b7c7145cb16"> However, this introduces an issue where clicking on the save icon actually triggers the parents play action - so that would need to be fixed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>