[PR #358] [MERGED] Fix queue behaviour when switching away from random #498

New issue

Closed

opened 2026-02-28 14:33:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/358
Author: @bivhitscar
Created: 11/19/2022
Status: ✅ Merged
Merged: 1/12/2023
Merged by: @Insprill

Base: master ← Head: fix_queue_behaviour_switching

📝 Commits (2)

4d9bc9d Fix queue behaviour when switching away from random
974911d Restore if let syntax

📊 Changes

1 file changed (+9 additions, -0 deletions)

View changed files

📝 psst-core/src/player/queue.rs (+9 -0)

📄 Description

Playback should proceed according to the currently selected queue behaviour. The implementation of random/shuffle was causing other options to fail if it had been previously selected.

This change restores the actual playlist position when switching queue behaviours, allowing for correct queue advancement at the end of the currently playing item.

To reproduce the original problem:
Open a playlist/album.
Select and play any item other than number 1*.
Select the random queue behaviour.
Select the loop all behaviour.
Click the skip to next item button.
When play advances to the next item, it will not be as expected (item 2 will probably play).

*The problem still exists from here, but is harder to spot.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/358 **Author:** [@bivhitscar](https://github.com/bivhitscar) **Created:** 11/19/2022 **Status:** ✅ Merged **Merged:** 1/12/2023 **Merged by:** [@Insprill](https://github.com/Insprill) **Base:** `master` ← **Head:** `fix_queue_behaviour_switching` --- ### 📝 Commits (2) - [`4d9bc9d`](https://github.com/jpochyla/psst/commit/4d9bc9d7c7bf2647ebc4fce7acd3d9ab56d0d540) Fix queue behaviour when switching away from random - [`974911d`](https://github.com/jpochyla/psst/commit/974911d70c586be8d8705acdee67f1ba2ac65c94) Restore if let syntax ### 📊 Changes **1 file changed** (+9 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `psst-core/src/player/queue.rs` (+9 -0) </details> ### 📄 Description Playback should proceed according to the currently selected queue behaviour. The implementation of random/shuffle was causing other options to fail if it had been previously selected. This change restores the actual playlist position when switching queue behaviours, allowing for correct queue advancement at the end of the currently playing item. To reproduce the original problem: Open a playlist/album. Select and play any item other than number 1*. Select the random queue behaviour. Select the loop all behaviour. Click the skip to next item button. When play advances to the next item, it will not be as expected (item 2 will probably play). *The problem still exists from here, but is harder to spot. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>