[PR #201] [MERGED] Add exit_code to Response from command_base and ResourceException #206

New issue

Closed

opened 2026-02-27 15:46:54 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:46:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/proxmoxer/proxmoxer/pull/201
Author: @jhollowe
Created: 2/18/2025
Status: ✅ Merged
Merged: 2/18/2025
Merged by: @jhollowe

Base: develop ← Head: cmd-exit-code

📝 Commits (2)

8808b69 Add exit_code to Response from command_base and ResourceException
cf1bcde Adjust tests for responses==0.25.5 changes

📊 Changes

13 files changed (+56 additions, -27 deletions)

View changed files

📝 proxmoxer/backends/command_base.py (+5 -4)
📝 proxmoxer/backends/local.py (+1 -1)
📝 proxmoxer/backends/openssh.py (+1 -1)
📝 proxmoxer/backends/ssh_paramiko.py (+1 -1)
📝 proxmoxer/core.py (+4 -1)
📝 tests/api_mock.py (+0 -3)
📝 tests/test_command_base.py (+20 -8)
📝 tests/test_core.py (+14 -2)
📝 tests/test_https.py (+1 -1)
📝 tests/test_local.py (+2 -1)
📝 tests/test_openssh.py (+3 -2)
📝 tests/test_paramiko.py (+3 -1)
📝 tests/tools/test_tasks.py (+1 -1)

📄 Description

for command-based backends (local, ssh_paramiko, openssh), adds exit_code property to the returned Response object. Also adds an optional exit_code property to ResourceException which is available for command-based backend exceptions.

fixes #172

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/proxmoxer/proxmoxer/pull/201 **Author:** [@jhollowe](https://github.com/jhollowe) **Created:** 2/18/2025 **Status:** ✅ Merged **Merged:** 2/18/2025 **Merged by:** [@jhollowe](https://github.com/jhollowe) **Base:** `develop` ← **Head:** `cmd-exit-code` --- ### 📝 Commits (2) - [`8808b69`](https://github.com/proxmoxer/proxmoxer/commit/8808b69905f0c9c4f0b7aee5863a44814d7cec39) Add exit_code to Response from command_base and ResourceException - [`cf1bcde`](https://github.com/proxmoxer/proxmoxer/commit/cf1bcde696537c74ef00d8e71fb86735fb4c2c79) Adjust tests for responses==0.25.5 changes ### 📊 Changes **13 files changed** (+56 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `proxmoxer/backends/command_base.py` (+5 -4) 📝 `proxmoxer/backends/local.py` (+1 -1) 📝 `proxmoxer/backends/openssh.py` (+1 -1) 📝 `proxmoxer/backends/ssh_paramiko.py` (+1 -1) 📝 `proxmoxer/core.py` (+4 -1) 📝 `tests/api_mock.py` (+0 -3) 📝 `tests/test_command_base.py` (+20 -8) 📝 `tests/test_core.py` (+14 -2) 📝 `tests/test_https.py` (+1 -1) 📝 `tests/test_local.py` (+2 -1) 📝 `tests/test_openssh.py` (+3 -2) 📝 `tests/test_paramiko.py` (+3 -1) 📝 `tests/tools/test_tasks.py` (+1 -1) </details> ### 📄 Description for command-based backends (`local`, `ssh_paramiko`, `openssh`), adds `exit_code` property to the returned `Response` object. Also adds an optional `exit_code` property to `ResourceException` which is available for command-based backend exceptions. fixes #172 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>