[PR #187] [MERGED] Don't error when Proxmox task ID is returned #201

New issue

Closed

opened 2026-02-27 15:46:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:46:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/proxmoxer/proxmoxer/pull/187
Author: @asdorsey
Created: 11/22/2024
Status: ✅ Merged
Merged: 12/11/2024
Merged by: @jhollowe

Base: develop ← Head: 185_fix-false-positive-errors

📝 Commits (6)

01fb1f1 fix: don't add host to SSH base URL
78f0d8c fix: don't error when Proxmox task ID is returned
8a0ffe3 fix: use regex to identify UPID
b53bc22 fix: remove stuff from #186 that snuck in
b568e0a fix: test failures, also check stderr for task ID
3b713c4 fix: linter, missing escapes

📊 Changes

1 file changed (+15 additions, -8 deletions)

View changed files

📝 proxmoxer/backends/command_base.py (+15 -8)

📄 Description

Fixes #185

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/proxmoxer/proxmoxer/pull/187 **Author:** [@asdorsey](https://github.com/asdorsey) **Created:** 11/22/2024 **Status:** ✅ Merged **Merged:** 12/11/2024 **Merged by:** [@jhollowe](https://github.com/jhollowe) **Base:** `develop` ← **Head:** `185_fix-false-positive-errors` --- ### 📝 Commits (6) - [`01fb1f1`](https://github.com/proxmoxer/proxmoxer/commit/01fb1f18d2f887981d05d94ffc6f039dd30b93d1) fix: don't add host to SSH base URL - [`78f0d8c`](https://github.com/proxmoxer/proxmoxer/commit/78f0d8caed3199957c23891e0f52c598db597e09) fix: don't error when Proxmox task ID is returned - [`8a0ffe3`](https://github.com/proxmoxer/proxmoxer/commit/8a0ffe300fd54304f07feae772c08d762b031910) fix: use regex to identify UPID - [`b53bc22`](https://github.com/proxmoxer/proxmoxer/commit/b53bc22f142f6321d251c4bb35907068d3bf76e1) fix: remove stuff from #186 that snuck in - [`b568e0a`](https://github.com/proxmoxer/proxmoxer/commit/b568e0a499b3334b466168c9a0a964d79a6bb945) fix: test failures, also check stderr for task ID - [`3b713c4`](https://github.com/proxmoxer/proxmoxer/commit/3b713c4d02da4d8381c0c34cd7e8452287b63828) fix: linter, missing escapes ### 📊 Changes **1 file changed** (+15 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `proxmoxer/backends/command_base.py` (+15 -8) </details> ### 📄 Description Fixes #185 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>