[PR #103] [MERGED] Cleanup https backend #175

New issue

Closed

opened 2026-02-27 15:46:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:46:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/proxmoxer/proxmoxer/pull/103
Author: @jhollowe
Created: 7/6/2022
Status: ✅ Merged
Merged: 8/7/2022
Merged by: @jhollowe

Base: develop ← Head: cleanup-https

📝 Commits (6)

ed1b91b Refactor common arguments to base class
4c05cce Cleanup imports and remove unneeded helper function
a5ab1d8 Merge branch 'develop' into cleanup-https
0259aef Update pre-commit hooks and bandit baseline
6fd1b38 Add path_prefix argument for HTTPS backend
6797347 Fix broken code and remove tests for removed code

📊 Changes

7 files changed (+395 additions, -144 deletions)

View changed files

📝 .pre-commit-config.yaml (+3 -3)
📝 proxmoxer/backends/command_base.py (+2 -2)
📝 proxmoxer/backends/https.py (+45 -47)
📝 proxmoxer/backends/openssh.py (+2 -2)
📝 proxmoxer/backends/ssh_paramiko.py (+2 -2)
📝 tests/https_helpers_tests.py (+0 -42)
📝 tests/known_issues.json (+341 -46)

📄 Description

Removed py2 compatibility code
Moved as much as possible into superclasses
Added path_prefix argument to support Proxmox services behind reverse proxies
Updated pre-commit hook versions and bandit baseline
Changed ordering of arguments to Auth's (should not cause issues unless directly using Auth's)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/proxmoxer/proxmoxer/pull/103 **Author:** [@jhollowe](https://github.com/jhollowe) **Created:** 7/6/2022 **Status:** ✅ Merged **Merged:** 8/7/2022 **Merged by:** [@jhollowe](https://github.com/jhollowe) **Base:** `develop` ← **Head:** `cleanup-https` --- ### 📝 Commits (6) - [`ed1b91b`](https://github.com/proxmoxer/proxmoxer/commit/ed1b91b97aef762640a80e3f786ce93c0b0e808b) Refactor common arguments to base class - [`4c05cce`](https://github.com/proxmoxer/proxmoxer/commit/4c05cce84d6f9ace70afedadcc49c94bf7513291) Cleanup imports and remove unneeded helper function - [`a5ab1d8`](https://github.com/proxmoxer/proxmoxer/commit/a5ab1d82bdb29c52c52c6ba5bc56292444275e88) Merge branch 'develop' into cleanup-https - [`0259aef`](https://github.com/proxmoxer/proxmoxer/commit/0259aefa037306382d51cd563260f5ded811b085) Update pre-commit hooks and bandit baseline - [`6fd1b38`](https://github.com/proxmoxer/proxmoxer/commit/6fd1b388aa4ab4e680720c646c41700dc647d3e4) Add path_prefix argument for HTTPS backend - [`6797347`](https://github.com/proxmoxer/proxmoxer/commit/67973473fdc5c6af86a5e5f9955a29967f7a10ab) Fix broken code and remove tests for removed code ### 📊 Changes **7 files changed** (+395 additions, -144 deletions) <details> <summary>View changed files</summary> 📝 `.pre-commit-config.yaml` (+3 -3) 📝 `proxmoxer/backends/command_base.py` (+2 -2) 📝 `proxmoxer/backends/https.py` (+45 -47) 📝 `proxmoxer/backends/openssh.py` (+2 -2) 📝 `proxmoxer/backends/ssh_paramiko.py` (+2 -2) 📝 `tests/https_helpers_tests.py` (+0 -42) 📝 `tests/known_issues.json` (+341 -46) </details> ### 📄 Description * Removed py2 compatibility code * Moved as much as possible into superclasses * Added `path_prefix` argument to support Proxmox services behind reverse proxies * Updated pre-commit hook versions and bandit baseline * Changed ordering of arguments to Auth's (should not cause issues unless directly using Auth's) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 15:46:47 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/proxmoxer#175

No description provided.

Rows
Columns