mirror of
https://github.com/proxmoxer/proxmoxer.git
synced 2026-04-25 07:06:00 +03:00
[GH-ISSUE #185] False positive error 500 when using SSH backends #103
Labels
No labels
backend:https
backend:local
backend:openssh
backend:ssh_paramiko
pull-request
status:ansible-issue
status:help-wanted
status:info-needed
status:proxmox-issue
status:review-needed
type:bug 🐞
type:dependency ⛓️
type:docs 📝
type:enhancement ⏫
type:maintenance 🛠️
type:meta
type:question ❓
type:request ✋
type:testing 🧪
version:1.x
version:latest
version:py2
version:py3
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/proxmoxer#103
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @asdorsey on GitHub (Nov 22, 2024).
Original GitHub issue: https://github.com/proxmoxer/proxmoxer/issues/185
When checking for errors at
github.com/proxmoxer/proxmoxer@f2394226a1/proxmoxer/backends/command_base.py (L113-L124), proxmoxer sometimes falsely detects certain commands as errors.I ran into this issue when using proxmoxer to reload the host networking configuration (
proxmoxer.nodes(node_name).network.put()).I have a potential fix, so I will file a PR immediately after I submit this ticket.
@asdorsey commented on GitHub (Nov 22, 2024):
PR #187 filed; it fixes this issue by assuming that a request succeeded if Proxmox returns a task ID.