[GH-ISSUE #358] Hide cloud-init data when no cloud-init disk is present? #87

New issue

Open

opened 2026-02-28 00:40:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:40:31 +03:00

Owner

Originally created by @Tinyblargon on GitHub (Aug 16, 2024).
Original GitHub issue: https://github.com/Telmate/proxmox-api-go/issues/358

Should we return a ConfigQemu.CloudInit object when no cloud-init disk has been configured?
When no cloud-init disk is configured the settings don't do anything. The PVE gui still shows the information all be it grayed out.

I do feel like checking if ConfigQemu.CloudInit == nil is the most intuitive way of checking if the vm uses cloud-init settings.
The alternative would be to check if a cloud-init disk is configured and check if ConfigQemu.CloudInit == nil.
Making users check if a cloud-init disk is configured feels like a lot to ask, especially with how the disks are implemented.
so we should make ConfigQemu.CloudInit = nil when no cloud-init disk is configured.

@mleone87 whats your opinion on this?

github.com/Telmate/proxmox-api-go@602cfe748b/proxmox/config_qemu.go (L32-L39)

Originally created by @Tinyblargon on GitHub (Aug 16, 2024). Original GitHub issue: https://github.com/Telmate/proxmox-api-go/issues/358 Should we return a `ConfigQemu.CloudInit` object when no cloud-init disk has been configured? When no cloud-init disk is configured the settings don't do anything. The PVE gui still shows the information all be it grayed out. I do feel like checking if `ConfigQemu.CloudInit == nil` is the most intuitive way of checking if the vm uses cloud-init settings. The alternative would be to check if a cloud-init disk is configured and check if `ConfigQemu.CloudInit == nil`. Making users check if a cloud-init disk is configured feels like a lot to ask, especially with how the disks are implemented. so we should make `ConfigQemu.CloudInit = nil` when no cloud-init disk is configured. @mleone87 whats your opinion on this? https://github.com/Telmate/proxmox-api-go/blob/602cfe748bbaf65a06298ffffa1a65ee063974cc/proxmox/config_qemu.go#L32-L39