mirror of
https://github.com/Telmate/proxmox-api-go.git
synced 2026-04-25 23:45:55 +03:00
[PR #87] [CLOSED] Added ability to parse IPv6 addresses with zone indices #217
Labels
No labels
good first issue
issue/confirmed
issue/critical
proposal/accepted
pull-request
type/bug
type/enhancement
type/feature
type/question
type/refactoring
type/testing
type/testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/proxmox-api-go#217
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Telmate/proxmox-api-go/pull/87
Author: @paginabianca
Created: 8/4/2020
Status: ❌ Closed
Base:
master← Head:IPv6-Zone-Index-Fix📝 Commits (1)
8b5a2f2Added ability to parse IPv6 addresses with zone indices📊 Changes
1 file changed (+3 additions, -3 deletions)
View changed files
📝
proxmox/client.go(+3 -3)📄 Description
If a VM has an interface that has an IPv6 address with a zone index, the API is not able to parse the address and fails when calling
AgentNetworkInterface.This is because
ParseIPis used to parse the IP returned by Proxmox. By replacing that withParseIPZone, scoped literal IPv6 addresses could be parsed correctly.I changed the type to IPAddr, a struct of IP and a string for the zone.
I'm not sure if the changes that I made are correct. I'm really new to golang and creating PRs so any feedback is welcome.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.