[PR #502] [MERGED] Migrate: add cli get acmeplugin #513

New issue

Closed

opened 2026-02-28 00:42:29 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/502
Author: @NemoDacremont
Created: 10/30/2025
Status: ✅ Merged
Merged: 11/4/2025
Merged by: @Tinyblargon

Base: master ← Head: migrate/cli-get-acmeplugin

📝 Commits (2)

f96a7d6 migrate: add get acmeplugin to new cli
885a3db fix: acme plugin parsing from API not taking type=standalone in account

📊 Changes

3 files changed (+37 additions, -4 deletions)

View changed files

➕ cli/command/get/get-acmeplugin.go (+18 -0)
📝 cli/command/get/get.go (+5 -0)
📝 proxmox/config__acme__plugin.go (+14 -4)

📄 Description

This PR solves the bug explained in #501 which would make the SDK crash when parsing acme plugin from API.

What was done :

Add get acmeplugin PLUGINID to the new CLI
Add digest field in AcmePlugin config which is returned by the API
Add type field which is returned by the API and defines how the plugin should be parsed
Set omitempty to fields that are only set when type="dns" since they are not relevant when type="standalone"

closes #500
closes #501

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/502 **Author:** [@NemoDacremont](https://github.com/NemoDacremont) **Created:** 10/30/2025 **Status:** ✅ Merged **Merged:** 11/4/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `migrate/cli-get-acmeplugin` --- ### 📝 Commits (2) - [`f96a7d6`](https://github.com/Telmate/proxmox-api-go/commit/f96a7d639a268bf9a47771724a964fab980c431e) migrate: add get acmeplugin to new cli - [`885a3db`](https://github.com/Telmate/proxmox-api-go/commit/885a3db323ced6e485469469b740415b7bd25956) fix: acme plugin parsing from API not taking type=standalone in account ### 📊 Changes **3 files changed** (+37 additions, -4 deletions) <details> <summary>View changed files</summary> ➕ `cli/command/get/get-acmeplugin.go` (+18 -0) 📝 `cli/command/get/get.go` (+5 -0) 📝 `proxmox/config__acme__plugin.go` (+14 -4) </details> ### 📄 Description This PR solves the bug explained in #501 which would make the SDK crash when parsing acme plugin from API. What was done : * Add `get acmeplugin PLUGINID` to the new CLI * Add digest field in AcmePlugin config which is returned by the API * Add type field which is returned by the API and defines how the plugin should be parsed * Set omitempty to fields that are only set when `type="dns"` since they are not relevant when `type="standalone"` closes #500 closes #501 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>