[PR #484] [MERGED] fix: remove the race condition merging the start/stop with other lxc tests #502

New issue

Closed

opened 2026-02-28 00:42:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/484
Author: @NemoDacremont
Created: 10/19/2025
Status: ✅ Merged
Merged: 10/20/2025
Merged by: @Tinyblargon

Base: master ← Head: fix/lxc-race-condition

📝 Commits (1)

c76e5bf fix: remove the race condition once for all by merging the start/stop test into the lxc tests

📊 Changes

2 files changed (+16 additions, -46 deletions)

View changed files

📝 test/api/Lxc/lxc_create_update_delete_test.go (+16 -0)
➖ test/api/Lxc/lxc_start_test.go (+0 -46)

📄 Description

I figured out that despite the previous efforts to prevent this race condition, it happened to fail because of lxc template was being downloaded for the first create, update and delete test, and it was trying to download it again for the second one. Because the download operation had been sent, it skipped the download, but because it was not finished, the LXC creation failed.

I think it is not that bad to move these tests in one file and forget about this race condition

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/484 **Author:** [@NemoDacremont](https://github.com/NemoDacremont) **Created:** 10/19/2025 **Status:** ✅ Merged **Merged:** 10/20/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `fix/lxc-race-condition` --- ### 📝 Commits (1) - [`c76e5bf`](https://github.com/Telmate/proxmox-api-go/commit/c76e5bf842c14824aade5fd843f681cc7d302d28) fix: remove the race condition once for all by merging the start/stop test into the lxc tests ### 📊 Changes **2 files changed** (+16 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `test/api/Lxc/lxc_create_update_delete_test.go` (+16 -0) ➖ `test/api/Lxc/lxc_start_test.go` (+0 -46) </details> ### 📄 Description I figured out that despite the previous efforts to prevent this race condition, it happened to fail because of lxc template was being downloaded for the first create, update and delete test, and it was trying to download it again for the second one. Because the download operation had been sent, it skipped the download, but because it was not finished, the LXC creation failed. I think it is not that bad to move these tests in one file and forget about this race condition --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>