[PR #480] [MERGED] fix: Uses wrong stop on pre v8.0 #499

New issue

Closed

opened 2026-02-28 00:42:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/480
Author: @Tinyblargon
Created: 10/9/2025
Status: ✅ Merged
Merged: 10/9/2025
Merged by: @Tinyblargon

Base: master ← Head: #479

📝 Commits (4)

0d8d8b9 fix: Uses wrong stop on pre v8.0
82f4d41 fix: typo
6dbc89d fix: typo
4eea218 refactor: make VmRef.Delete() mockable

📊 Changes

6 files changed (+106 additions, -26 deletions)

View changed files

📝 proxmox/client__api.go (+6 -0)
📝 proxmox/client__api__mock.go (+8 -0)
📝 proxmox/client__new.go (+3 -0)
📝 proxmox/client__new__mock.go (+24 -0)
📝 proxmox/error.go (+23 -0)
📝 proxmox/vmref.go (+42 -26)

📄 Description

VmRef.Delete() fails because force stop is not supported before PVE 8.0.0

Fixes #479

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/480 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 10/9/2025 **Status:** ✅ Merged **Merged:** 10/9/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `#479` --- ### 📝 Commits (4) - [`0d8d8b9`](https://github.com/Telmate/proxmox-api-go/commit/0d8d8b97f357efb0bc192746b9f8e4c01af393cc) fix: Uses wrong stop on pre v8.0 - [`82f4d41`](https://github.com/Telmate/proxmox-api-go/commit/82f4d41937599901213d2aeb54b007927dbc3be5) fix: typo - [`6dbc89d`](https://github.com/Telmate/proxmox-api-go/commit/6dbc89dffa89fd83452260832d3b5b5820cc1731) fix: typo - [`4eea218`](https://github.com/Telmate/proxmox-api-go/commit/4eea21892f3fd2ab364d0febd29d8d20d91b108e) refactor: make `VmRef.Delete()` mockable ### 📊 Changes **6 files changed** (+106 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/client__api.go` (+6 -0) 📝 `proxmox/client__api__mock.go` (+8 -0) 📝 `proxmox/client__new.go` (+3 -0) 📝 `proxmox/client__new__mock.go` (+24 -0) 📝 `proxmox/error.go` (+23 -0) 📝 `proxmox/vmref.go` (+42 -26) </details> ### 📄 Description `VmRef.Delete()` fails because force stop is not supported before PVE 8.0.0 Fixes #479 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>