[PR #450] [MERGED] Move Delete into SDK #480

New issue

Closed

opened 2026-02-28 00:42:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/450
Author: @Tinyblargon
Created: 8/21/2025
Status: ✅ Merged
Merged: 8/21/2025
Merged by: @Tinyblargon

Base: master ← Head: tf-#1377

📝 Commits (10+)

0ee5f6c refactor: rename function
94b4a8d feat: add validation and NoCheck variant
133bf88 feat: LXC Protection
e4cd024 refactor: use GuestID for pool
7a62f87 feat: getResourceList_Unsafe()
fd1f560 feat: RawGuestResources
eee81bf feat: RawGuestResources.SelectID()
0a4d41f feat: VmRef.Delete()
2c1df7e feat: deprecate vm delete and stop
829bc99 perf: use unsafe calls for new LXC

📊 Changes

36 files changed (+925 additions, -545 deletions)

View changed files

📝 cli/command/delete/delete-guest.go (+1 -6)
📝 cli/command/guest/guest-stop.go (+1 -2)
📝 main.go (+2 -9)
📝 proxmox/client.go (+14 -9)
📝 proxmox/config__guest.go (+19 -115)
➕ proxmox/config__guest__resource.go (+235 -0)
➕ proxmox/config__guest__resource_test.go (+207 -0)
📝 proxmox/config__guest_test.go (+0 -222)
📝 proxmox/config__lxc__cpu.go (+3 -9)
📝 proxmox/config__lxc__new.go (+53 -14)
📝 proxmox/config__lxc__new_test.go (+94 -4)
📝 proxmox/config__pool.go (+38 -43)
📝 proxmox/config__pool_test.go (+34 -34)
📝 proxmox/config__qemu.go (+13 -3)
📝 proxmox/config__qemu__cloudinit.go (+4 -8)
📝 proxmox/config__qemu__disk.go (+2 -6)
📝 proxmox/config__qemu__network.go (+2 -4)
📝 proxmox/config__qemu__pcie.go (+8 -14)
📝 proxmox/config__qemu__serial.go (+1 -3)
📝 proxmox/config__qemu__usb.go (+4 -10)

...and 16 more files

📄 Description

Moves the delete logic from github.com/Telmate/terraform-provider-proxmox@cec3174a02/proxmox/helper_guest.go into the SDK.

Reworks and optimizes many areas that are used for the delete logic.

SDK side of https://github.com/Telmate/terraform-provider-proxmox/issues/1377

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/450 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 8/21/2025 **Status:** ✅ Merged **Merged:** 8/21/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `tf-#1377` --- ### 📝 Commits (10+) - [`0ee5f6c`](https://github.com/Telmate/proxmox-api-go/commit/0ee5f6c1a6f28f3fee3e33ff9c849e24f1bfca40) refactor: rename function - [`94b4a8d`](https://github.com/Telmate/proxmox-api-go/commit/94b4a8d39434025d2e445a10064bc2aaaa18694a) feat: add validation and NoCheck variant - [`133bf88`](https://github.com/Telmate/proxmox-api-go/commit/133bf885e8d12c5513074e090cb06886194c442b) feat: LXC Protection - [`e4cd024`](https://github.com/Telmate/proxmox-api-go/commit/e4cd0243d6c7d99fb8910ef150dfab0ec8aee74d) refactor: use `GuestID` for pool - [`7a62f87`](https://github.com/Telmate/proxmox-api-go/commit/7a62f875358d818ac0bab729c21fde341f8e99b2) feat: `getResourceList_Unsafe()` - [`fd1f560`](https://github.com/Telmate/proxmox-api-go/commit/fd1f5602fe7440079a7251774b8379015aec6978) feat: RawGuestResources - [`eee81bf`](https://github.com/Telmate/proxmox-api-go/commit/eee81bf86667f848d710701643e5ff2b2368d37c) feat: `RawGuestResources.SelectID()` - [`0a4d41f`](https://github.com/Telmate/proxmox-api-go/commit/0a4d41fcd46da738c360b94a088fe1a8294fb314) feat: `VmRef.Delete()` - [`2c1df7e`](https://github.com/Telmate/proxmox-api-go/commit/2c1df7e09c9080dd9389061bd9b8ea293e349d2a) feat: deprecate vm delete and stop - [`829bc99`](https://github.com/Telmate/proxmox-api-go/commit/829bc99f746cb9198d9b47d511b62b7f8d07a1df) perf: use unsafe calls for new LXC ### 📊 Changes **36 files changed** (+925 additions, -545 deletions) <details> <summary>View changed files</summary> 📝 `cli/command/delete/delete-guest.go` (+1 -6) 📝 `cli/command/guest/guest-stop.go` (+1 -2) 📝 `main.go` (+2 -9) 📝 `proxmox/client.go` (+14 -9) 📝 `proxmox/config__guest.go` (+19 -115) ➕ `proxmox/config__guest__resource.go` (+235 -0) ➕ `proxmox/config__guest__resource_test.go` (+207 -0) 📝 `proxmox/config__guest_test.go` (+0 -222) 📝 `proxmox/config__lxc__cpu.go` (+3 -9) 📝 `proxmox/config__lxc__new.go` (+53 -14) 📝 `proxmox/config__lxc__new_test.go` (+94 -4) 📝 `proxmox/config__pool.go` (+38 -43) 📝 `proxmox/config__pool_test.go` (+34 -34) 📝 `proxmox/config__qemu.go` (+13 -3) 📝 `proxmox/config__qemu__cloudinit.go` (+4 -8) 📝 `proxmox/config__qemu__disk.go` (+2 -6) 📝 `proxmox/config__qemu__network.go` (+2 -4) 📝 `proxmox/config__qemu__pcie.go` (+8 -14) 📝 `proxmox/config__qemu__serial.go` (+1 -3) 📝 `proxmox/config__qemu__usb.go` (+4 -10) _...and 16 more files_ </details> ### 📄 Description Moves the delete logic from https://github.com/Telmate/terraform-provider-proxmox/blob/cec3174a029e2dbd053296731c9509b6bf54adad/proxmox/helper_guest.go into the SDK. Reworks and optimizes many areas that are used for the delete logic. SDK side of https://github.com/Telmate/terraform-provider-proxmox/issues/1377 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>