[PR #459] [MERGED] Feat: get pending config #486

New issue

Closed

opened 2026-02-28 00:42:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/459
Author: @Tinyblargon
Created: 9/15/2025
Status: ✅ Merged
Merged: 9/16/2025
Merged by: @Tinyblargon

Base: master ← Head: #458

📝 Commits (5)

f939f8a feat: check "data" key exists
065f6aa feat: get pending changes
b16e66a test: use mock for deeper test
0d49f3c feat: get active config
1848e54 docs: use correct terms for qemu & lxc

📊 Changes

12 files changed (+478 additions, -38 deletions)

View changed files

📝 proxmox/client__api.go (+5 -0)
📝 proxmox/client__api__mock.go (+12 -4)
📝 proxmox/client__api__reusable.go (+7 -4)
📝 proxmox/client__new.go (+27 -1)
📝 proxmox/client__new__mock.go (+35 -3)
📝 proxmox/config__guest.go (+2 -12)
📝 proxmox/config__lxc__new.go (+24 -1)
📝 proxmox/config__lxc__new_test.go (+116 -2)
📝 proxmox/config__qemu.go (+37 -11)
📝 proxmox/config__qemu_test.go (+136 -0)
📝 proxmox/vmref.go (+38 -0)
📝 proxmox/vmref_test.go (+39 -0)

📄 Description

Add ways to check if there are pending config changes.
Add a way to get the active config, as the normal config has the pending changes included.
Improved some tests due to the new mocks.

Closes #458

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/459 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 9/15/2025 **Status:** ✅ Merged **Merged:** 9/16/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `#458` --- ### 📝 Commits (5) - [`f939f8a`](https://github.com/Telmate/proxmox-api-go/commit/f939f8aacd4a4c65ba375743cc7fb2bbd95c8851) feat: check `"data"` key exists - [`065f6aa`](https://github.com/Telmate/proxmox-api-go/commit/065f6aace15d80cb1afa415c09dfe02cc6d936b6) feat: get pending changes - [`b16e66a`](https://github.com/Telmate/proxmox-api-go/commit/b16e66a677ed6a17eba64891e09304a80450ede2) test: use mock for deeper test - [`0d49f3c`](https://github.com/Telmate/proxmox-api-go/commit/0d49f3c8c0cd9df9877c59b8f065cd72f771600c) feat: get active config - [`1848e54`](https://github.com/Telmate/proxmox-api-go/commit/1848e546b45de44cb361231eca82767736d28f8c) docs: use correct terms for qemu & lxc ### 📊 Changes **12 files changed** (+478 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/client__api.go` (+5 -0) 📝 `proxmox/client__api__mock.go` (+12 -4) 📝 `proxmox/client__api__reusable.go` (+7 -4) 📝 `proxmox/client__new.go` (+27 -1) 📝 `proxmox/client__new__mock.go` (+35 -3) 📝 `proxmox/config__guest.go` (+2 -12) 📝 `proxmox/config__lxc__new.go` (+24 -1) 📝 `proxmox/config__lxc__new_test.go` (+116 -2) 📝 `proxmox/config__qemu.go` (+37 -11) 📝 `proxmox/config__qemu_test.go` (+136 -0) 📝 `proxmox/vmref.go` (+38 -0) 📝 `proxmox/vmref_test.go` (+39 -0) </details> ### 📄 Description Add ways to check if there are pending config changes. Add a way to get the active config, as the normal config has the pending changes included. Improved some tests due to the new mocks. Closes #458 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>