[PR #424] [MERGED] Fix: lxc bugs #458

New issue

Closed

opened 2026-02-28 00:42:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/424
Author: @Tinyblargon
Created: 6/10/2025
Status: ✅ Merged
Merged: 6/10/2025
Merged by: @Tinyblargon

Base: master ← Head: new-lxc-bugs

📝 Commits (10+)

f1f6786 fix: lxc tries to create qemu
2ad482e fix: qemu vmType returned
ee27a08 fix: size should be required during creation
3de4ef9 fix: LxcBootMount settings not set
637c569 feat: required values never returned as nil
d49f2e2 feat: never nil when returned
b1e8867 refactor: make func safe
e8aaa1a fix: size not set during update
080ae05 feat: ACL and Replicate never nil when returned
93dd64c feat: lxc disk Quota

📊 Changes

8 files changed (+332 additions, -153 deletions)

View changed files

📝 proxmox/config_guest.go (+1 -1)
📝 proxmox/config_lxc__cpu.go (+12 -3)
📝 proxmox/config_lxc__cpu_test.go (+8 -3)
📝 proxmox/config_lxc__mount.go (+82 -46)
📝 proxmox/config_lxc__mount_test.go (+23 -1)
📝 proxmox/config_lxc_new.go (+26 -18)
📝 proxmox/config_lxc_new_test.go (+178 -80)
📝 proxmox/util.go (+2 -1)

📄 Description

Lots and lots of minor bug fixes for the new LXC implementation.
Came across these bug while implementing the Terraform provider.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/424 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 6/10/2025 **Status:** ✅ Merged **Merged:** 6/10/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `new-lxc-bugs` --- ### 📝 Commits (10+) - [`f1f6786`](https://github.com/Telmate/proxmox-api-go/commit/f1f6786cb8ab14a35d48058df699a70c587b5733) fix: lxc tries to create qemu - [`2ad482e`](https://github.com/Telmate/proxmox-api-go/commit/2ad482ef967131ead00ca4e2ad09e7b29ad6ba97) fix: qemu vmType returned - [`ee27a08`](https://github.com/Telmate/proxmox-api-go/commit/ee27a08d0cd10305d0eabe3a67c2ed4f1ff46d09) fix: size should be required during creation - [`3de4ef9`](https://github.com/Telmate/proxmox-api-go/commit/3de4ef978274aa326383814d6591adb4ec98272e) fix: LxcBootMount settings not set - [`637c569`](https://github.com/Telmate/proxmox-api-go/commit/637c569b4d571e0960e53f707f728bbd9f7cbfc4) feat: required values never returned as `nil` - [`d49f2e2`](https://github.com/Telmate/proxmox-api-go/commit/d49f2e2f5cc1fb040bf24f4cd69ed1ece4df0669) feat: never `nil` when returned - [`b1e8867`](https://github.com/Telmate/proxmox-api-go/commit/b1e886799e26ce4bd20a2a11427488801df911bb) refactor: make func safe - [`e8aaa1a`](https://github.com/Telmate/proxmox-api-go/commit/e8aaa1a0061b95f2243b479430fe4967e5480327) fix: size not set during update - [`080ae05`](https://github.com/Telmate/proxmox-api-go/commit/080ae0583cb6f63f84a27f6adef632175ab91abf) feat: `ACL` and `Replicate` never nil when returned - [`93dd64c`](https://github.com/Telmate/proxmox-api-go/commit/93dd64c8939a77bf47710396272349d696bedfb5) feat: lxc disk `Quota` ### 📊 Changes **8 files changed** (+332 additions, -153 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_guest.go` (+1 -1) 📝 `proxmox/config_lxc__cpu.go` (+12 -3) 📝 `proxmox/config_lxc__cpu_test.go` (+8 -3) 📝 `proxmox/config_lxc__mount.go` (+82 -46) 📝 `proxmox/config_lxc__mount_test.go` (+23 -1) 📝 `proxmox/config_lxc_new.go` (+26 -18) 📝 `proxmox/config_lxc_new_test.go` (+178 -80) 📝 `proxmox/util.go` (+2 -1) </details> ### 📄 Description Lots and lots of minor bug fixes for the new LXC implementation. Came across these bug while implementing the Terraform provider. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>