[PR #453] [MERGED] Refactot raw config #483

New issue

Closed

opened 2026-02-28 00:42:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/453
Author: @Tinyblargon
Created: 8/24/2025
Status: ✅ Merged
Merged: 8/24/2025
Merged by: @Tinyblargon

Base: master ← Head: #430

📝 Commits (3)

d1fa68a docs: Update styleguide
48d2556 feat: RawConfigPool
a012c40 refactor: move map into private field

📊 Changes

28 files changed (+411 additions, -380 deletions)

View changed files

📝 docs/style-guide/sdk.md (+19 -17)
📝 proxmox/config__guest__resource.go (+66 -66)
📝 proxmox/config__guest__resource_test.go (+25 -25)
📝 proxmox/config__lxc__cpu.go (+3 -3)
📝 proxmox/config__lxc__features.go (+1 -1)
📝 proxmox/config__lxc__features_test.go (+2 -2)
📝 proxmox/config__lxc__mount.go (+2 -2)
📝 proxmox/config__lxc__mount_test.go (+2 -2)
📝 proxmox/config__lxc__networks.go (+1 -1)
📝 proxmox/config__lxc__new.go (+16 -16)
📝 proxmox/config__lxc__new_test.go (+92 -93)
📝 proxmox/config__pool.go (+62 -41)
📝 proxmox/config__pool_test.go (+23 -14)
📝 proxmox/config__qemu.go (+11 -11)
📝 proxmox/config__qemu__cloudinit.go (+7 -7)
📝 proxmox/config__qemu__cpu.go (+8 -8)
📝 proxmox/config__qemu__disk__ide.go (+4 -4)
📝 proxmox/config__qemu__disk__sata.go (+6 -6)
📝 proxmox/config__qemu__disk__scsi.go (+31 -31)
📝 proxmox/config__qemu__disk__virtio.go (+16 -16)

...and 8 more files

📄 Description

Adds RawPoolConfig.
Refactors raw configs so the map[string]any is in only accessible trough the Get methods.
Update style guide to reflect change in raw.

Closes #430

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/453 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 8/24/2025 **Status:** ✅ Merged **Merged:** 8/24/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `#430` --- ### 📝 Commits (3) - [`d1fa68a`](https://github.com/Telmate/proxmox-api-go/commit/d1fa68a3b82214a986ecdabd76c8f061ab97fa41) docs: Update styleguide - [`48d2556`](https://github.com/Telmate/proxmox-api-go/commit/48d255637048b9fa975eb6de8b103813a56b36a1) feat: RawConfigPool - [`a012c40`](https://github.com/Telmate/proxmox-api-go/commit/a012c40524d07fb4d4d3a993e1922a5d33eb664e) refactor: move map into private field ### 📊 Changes **28 files changed** (+411 additions, -380 deletions) <details> <summary>View changed files</summary> 📝 `docs/style-guide/sdk.md` (+19 -17) 📝 `proxmox/config__guest__resource.go` (+66 -66) 📝 `proxmox/config__guest__resource_test.go` (+25 -25) 📝 `proxmox/config__lxc__cpu.go` (+3 -3) 📝 `proxmox/config__lxc__features.go` (+1 -1) 📝 `proxmox/config__lxc__features_test.go` (+2 -2) 📝 `proxmox/config__lxc__mount.go` (+2 -2) 📝 `proxmox/config__lxc__mount_test.go` (+2 -2) 📝 `proxmox/config__lxc__networks.go` (+1 -1) 📝 `proxmox/config__lxc__new.go` (+16 -16) 📝 `proxmox/config__lxc__new_test.go` (+92 -93) 📝 `proxmox/config__pool.go` (+62 -41) 📝 `proxmox/config__pool_test.go` (+23 -14) 📝 `proxmox/config__qemu.go` (+11 -11) 📝 `proxmox/config__qemu__cloudinit.go` (+7 -7) 📝 `proxmox/config__qemu__cpu.go` (+8 -8) 📝 `proxmox/config__qemu__disk__ide.go` (+4 -4) 📝 `proxmox/config__qemu__disk__sata.go` (+6 -6) 📝 `proxmox/config__qemu__disk__scsi.go` (+31 -31) 📝 `proxmox/config__qemu__disk__virtio.go` (+16 -16) _...and 8 more files_ </details> ### 📄 Description - Adds `RawPoolConfig`. - Refactors raw configs so the `map[string]any` is in only accessible trough the `Get` methods. - Update style guide to reflect change in raw. Closes #430 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>