[PR #385] [MERGED] feat: use same mac address case #430

Closed
opened 2026-02-28 00:42:10 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/385
Author: @Tinyblargon
Created: 11/26/2024
Status: Merged
Merged: 11/27/2024
Merged by: @Tinyblargon

Base: masterHead: #384


📝 Commits (2)

  • 1640bcb feat: use same mac address case
  • 68bb40d refactor: remove extra check for model

📊 Changes

2 files changed (+54 additions, -11 deletions)

View changed files

📝 proxmox/config_qemu_network.go (+16 -8)
📝 proxmox/config_qemu_test.go (+38 -3)

📄 Description

when the binary value of the mac address does not change re-use the current string representation.

resolves #384


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/385 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 11/26/2024 **Status:** ✅ Merged **Merged:** 11/27/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `#384` --- ### 📝 Commits (2) - [`1640bcb`](https://github.com/Telmate/proxmox-api-go/commit/1640bcb484a80611b48e2d58528b40a7aa1eed2e) feat: use same mac address case - [`68bb40d`](https://github.com/Telmate/proxmox-api-go/commit/68bb40da69ffd28a406de326ada2f77b8f1020da) refactor: remove extra check for `model` ### 📊 Changes **2 files changed** (+54 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu_network.go` (+16 -8) 📝 `proxmox/config_qemu_test.go` (+38 -3) </details> ### 📄 Description when the binary value of the mac address does not change re-use the current string representation. resolves #384 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 00:42:10 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/proxmox-api-go#430
No description provided.