[PR #421] [MERGED] Reimplement LXC #457

New issue

Closed

opened 2026-02-28 00:42:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/421
Author: @Tinyblargon
Created: 6/6/2025
Status: ✅ Merged
Merged: 6/6/2025
Merged by: @Tinyblargon

Base: master ← Head: lxc

📝 Commits (10+)

2185aef feat: start of new LXC implementation
faaeb4b feat: type GuestName
f003f4d feat: RawConfigLXC type
6adf2be feat: minimal LxcBootMount implementation
ad52d9c refactor: change order of tests
3e4d4d5 refactor: replace inArray with slices.Contains
69054ad test: add LxcMemory.String()
7509c2a refactor: move ID to right location
1ea35b3 refactor: reduce nested if statements
c08f33e feat: type LxcSwap

📊 Changes

36 files changed (+4864 additions, -463 deletions)

View changed files

📝 docs/style-guide/sdk.md (+52 -28)
📝 proxmox/config_acme_account.go (+3 -1)
📝 proxmox/config_guest.go (+171 -3)
📝 proxmox/config_guest_test.go (+53 -0)
➕ proxmox/config_lxc__cpu.go (+168 -0)
➕ proxmox/config_lxc__cpu_test.go (+114 -0)
➕ proxmox/config_lxc__features.go (+144 -0)
➕ proxmox/config_lxc__mount.go (+222 -0)
➕ proxmox/config_lxc__mount_test.go (+11 -0)
➕ proxmox/config_lxc__networks.go (+667 -0)
➕ proxmox/config_lxc__networks_test.go (+359 -0)
➕ proxmox/config_lxc_new.go (+488 -0)
➕ proxmox/config_lxc_new_test.go (+1781 -0)
📝 proxmox/config_qemu.go (+21 -7)
📝 proxmox/config_qemu_cloudinit.go (+7 -121)
📝 proxmox/config_qemu_cloudinit_test.go (+0 -104)
📝 proxmox/config_qemu_network.go (+12 -67)
📝 proxmox/config_qemu_network_test.go (+7 -28)
📝 proxmox/config_qemu_test.go (+83 -40)
📝 proxmox/config_storage.go (+9 -8)

...and 16 more files

📄 Description

This is a basic re-implementation of LXC.
All code that was changed for the LXC implementation has been tested, but the LXC implementation itself has not been tested yet.
One change has been made to the style guide as the way LXC is converting the API response to a config is way more ergonomic.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/421 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 6/6/2025 **Status:** ✅ Merged **Merged:** 6/6/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `lxc` --- ### 📝 Commits (10+) - [`2185aef`](https://github.com/Telmate/proxmox-api-go/commit/2185aefcd3a67219ffe48354fb65bac0885b8406) feat: start of new LXC implementation - [`faaeb4b`](https://github.com/Telmate/proxmox-api-go/commit/faaeb4be7a6368605b8be7008a2df325ca08efa1) feat: type `GuestName` - [`f003f4d`](https://github.com/Telmate/proxmox-api-go/commit/f003f4d4475eef2effef80d580167f433faea0c7) feat: `RawConfigLXC` type - [`6adf2be`](https://github.com/Telmate/proxmox-api-go/commit/6adf2be3b372be5cd1aa6c51b9ac7c23ee8d622f) feat: minimal `LxcBootMount` implementation - [`ad52d9c`](https://github.com/Telmate/proxmox-api-go/commit/ad52d9c84e1499182cd51074d57f311aa3b0d061) refactor: change order of tests - [`3e4d4d5`](https://github.com/Telmate/proxmox-api-go/commit/3e4d4d5c6f17ffc1e07ddb581f4bb709b0118491) refactor: replace `inArray` with `slices.Contains` - [`69054ad`](https://github.com/Telmate/proxmox-api-go/commit/69054ad072ac6214ba6198bce55ca7407a747ee5) test: add `LxcMemory.String()` - [`7509c2a`](https://github.com/Telmate/proxmox-api-go/commit/7509c2a724279eafa56576cf2fb29eee3124bb00) refactor: move `ID` to right location - [`1ea35b3`](https://github.com/Telmate/proxmox-api-go/commit/1ea35b319e6a5051160495322af0757ffefe8a22) refactor: reduce nested if statements - [`c08f33e`](https://github.com/Telmate/proxmox-api-go/commit/c08f33e45570997245ac756276ed6950b85bcad4) feat: type `LxcSwap` ### 📊 Changes **36 files changed** (+4864 additions, -463 deletions) <details> <summary>View changed files</summary> 📝 `docs/style-guide/sdk.md` (+52 -28) 📝 `proxmox/config_acme_account.go` (+3 -1) 📝 `proxmox/config_guest.go` (+171 -3) 📝 `proxmox/config_guest_test.go` (+53 -0) ➕ `proxmox/config_lxc__cpu.go` (+168 -0) ➕ `proxmox/config_lxc__cpu_test.go` (+114 -0) ➕ `proxmox/config_lxc__features.go` (+144 -0) ➕ `proxmox/config_lxc__mount.go` (+222 -0) ➕ `proxmox/config_lxc__mount_test.go` (+11 -0) ➕ `proxmox/config_lxc__networks.go` (+667 -0) ➕ `proxmox/config_lxc__networks_test.go` (+359 -0) ➕ `proxmox/config_lxc_new.go` (+488 -0) ➕ `proxmox/config_lxc_new_test.go` (+1781 -0) 📝 `proxmox/config_qemu.go` (+21 -7) 📝 `proxmox/config_qemu_cloudinit.go` (+7 -121) 📝 `proxmox/config_qemu_cloudinit_test.go` (+0 -104) 📝 `proxmox/config_qemu_network.go` (+12 -67) 📝 `proxmox/config_qemu_network_test.go` (+7 -28) 📝 `proxmox/config_qemu_test.go` (+83 -40) 📝 `proxmox/config_storage.go` (+9 -8) _...and 16 more files_ </details> ### 📄 Description This is a basic re-implementation of LXC. All code that was changed for the LXC implementation has been tested, but the LXC implementation itself has not been tested yet. One change has been made to the style guide as the way LXC is converting the API response to a config is way more ergonomic. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>